Lunie: Let's hardwire default paths to Gaia.

[NodeGuy]

748 builds Gaia binaries into builds/gaia. If BINARY_PATH and NODE_BINARY_PATH aren't set then let's have Voyager look for them there, or even better let's hardwire the paths and get rid of BINARY_PATH and NODE_BINARY_PATH.

[faboweb]

Do we want devs to be able to overwrite the paths for some reasons?

David Braun [e-mail] schrieb am Fr., 1. Juni 2018, 21:34:

748 https://github.com/cosmos/voyager/pull/748 builds Gaia binaries

into builds/gaia. If BINARY_PATH and NODE_BINARY_PATH aren't set then
let's have Voyager look for them there, or even better let's hardwire the
paths and get rid of BINARY_PATH and NODE_BINARY_PATH.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/cosmos/voyager/issues/784, or mute the thread
https://github.com/notifications/unsubscribe-auth/AFmO2Y8LoBfnTWkw4_JTBEd1Air30ZQDks5t4ZdVgaJpZM4UXNTD
.

[NodeGuy]

I can't think of a reason. If a dev wants to use a different version of Gaia then he could specify a different version to be built.

[nylira]

The fewer configuration flags the better, I support this idea.

[jbibla]

i'd like us to revisit this!

[faboweb]

What do you mean? What do you propose?

[jbibla]

to run voyager i have to use this command:

BINARY_PATH=builds/Gaia/darwin_amd64/gaiacli NODE_BINARY_PATH=builds/Gaia/darwin_amd64/gaiad yarn testnet

but i'd like to be able to use this command:

yarn testnet

i think we're defaulting to local gaia instead of the gaia we're building with yarn build:gaia.

[faboweb]

👍 OK I got it. This should be an easy fix. The code handling the path is here: https://github.com/cosmos/voyager/blob/develop/app/src/main/index.js#L171

[faboweb]

I am sorry to bring this up again. But currently we the situation that some issues work on are on an old SDK version while others are on a newer SDK version. Having fixed paths for the binary would remove the ability to switch quickly between two SDK versions. Therefor I strongly disagree with getting rid of the binary path environment variables.

[okwme]

I thought this was w regard to letting the default gaia path point to the app-specific build, but still allowing setting the path explicitly for the scenario @faboweb outlined

[faboweb]

Then I got this wrong. Let's do it like that. :) Thank you for clarifying.

billy rennekamp [e-mail] schrieb am Do., 12. Juli 2018,
13:36:

I thought this was w regard to letting the default gaia path point to the
app-specific build, but still allowing setting the path explicitly for the
scenario @faboweb https://github.com/faboweb outlined

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
https://github.com/cosmos/voyager/issues/784#issuecomment-404482529, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFmO2csd6Z4vCAabF5qUuQcRGqzUxyKwks5uFzSugaJpZM4UXNTD
.