Luckperms: Issue with perma all permissions

Created on 11 May 2018 · 5Comments · Source: lucko/LuckPerms

The function removeAttachment doesnt seem to function properly (works in other permissions such as PermissionsEx) and the player is stuck with full permissions from the below code at least.

I am currently working on a recode however this code from the old builds should still be valid and I am pretty sure it is also how commandsigns does this too so it is a larger issue possibly.

Example of code that triggers the problem
try { permissionAttachment = player.addAttachment(plugin, "*", true); player.chat("/" + command); } finally { player.removeAttachment(permissionAttachment); }

One of my users was having trouble with this and using LuckPerms as the permission manager

issue

Source

sekwah41

Most helpful comment

The latter, should be fixed now

lucko on 13 May 2018

👍2

All 5 comments

Can confirm that this is happening on the latest development build. The permission stays only attached until the next logout. (so it's not added to the LuckPerms permissions, just looks like the removal is either broken or doesn't like that it happens in the same tick)

I did some testing and it looks like the issue was introduced somewhere between versions 4.1.25 (f969e2e52b5c3474cdc9b75208d5048d33f67b22) and 4.1.100 (c4c98aaabf0c2e4dec6644cdcf2957beb882cb3b). Unfortunately I can't find any builds between that to test :/

I kinda suspect 10c0efaa5d860bdf74e9ee56fed1b0ea0ad7c221 being the cause as that's the only one that seems to be touching that part. Gonna try to build the commit before that and test with it.

Update: Well that version was unusable due to the high CPU usage (who would've thought) but b8a1871cf172c6d0dcd34438c7f3b2fc78c56667 seems to work fine and so I suspect that the next one, which changes the caching behaviour (a6facf7492bd9006f3c7b4e059668e4912e39e55), is the cause for this bug or that it at least lies between these two commits. Can't really test that as it's resulting in the high CPU usage and crashing the server :/