Loris: [User Accounts] Test Plan #5 Failed

[sruthymathew123]

Describe the bug
Verify that if the editor does not have permission 'Across all sites add and edit users' then the site drop-down list is populated with the editor's associated sites, otherwise all sites are displayed.
This is failing

To Reproduce

1. Create a user with one site affiliation '...'
2. Make sure the created user has 'User Management' Permission
3. Verify that the created user does not have permission 'Across all sites add and edit users'
4. Login as that created user and now that user's site drop-down list is populated with all sites.

[johnsaigle]

I'm not able to reproduce this on my VM.

1. With Raisinbread on branch aces/23.0-release:
2. Create a user john with permission "User Management", site "Ottawa", Project "Rye" and no other permissions, sites, or projects
3. As john, go to User Accounts > Add User
4. On the edit_user page, this is displayed as Site and Project options for a new user:

Screenshot 1 - Add User from point of view of john

Screenshot 2 - Possible Sites and Projects from point of view of super user admin

[johnsaigle]

I did notice that the Site filter from the user_accounts page displays all users across sites, however. Is that what you meant?

[sruthymathew123]

@johnsaigle Yes, that is what I meant.

[johnsaigle]

It looks like this line should be deleted from the test plan.

It was added here https://github.com/aces/Loris/pull/4786/ to fix this issue https://github.com/aces/Loris/issues/4741. However, the issue doesn't mention anything about the Site field being pre-populated with the user's sites and I'm not sure this was ever a feature.

I also don't know if this is possible to do given the way the filter works. It's a dropdown, not a multi-select. So if a user has two sites, Montreal and Ottawa, there is no way to populate both of them at once within the site dropdown.

[sruthymathew123]

@johnsaigle In that case, as you mentioned the line should be deleted from test plan. Otherwise it will be confusing.

[johnsaigle]

I can remove it now Actually we seem to have some interested contributors so I'll create a new issue for this and mark it as beginner friendly.

[johnsaigle]

This can be closed when #6320 is merged.