Loris: Fix JS lint warnings

Created on 21 Nov 2018  路  7Comments  路  Source: aces/Loris

There are many JavaScript files within the code base that generate warnings in our automated testing procedure. Most of them have to do with lines being too long or functions missing documentation.

Fixing these warnings would be a good way for someone new to get familiar with the code base as well as to learn our code review procedure.

TODO

  • On a development instance of LORIS run npm run lint:javascript
  • Issue a pull request that eliminates warnings
Beginner Friendly Bug Cleanup Stale

All 7 comments

Note: you don't need to fix all of the warnings, fixing some of them would still be a step forward.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@driusan This one has been untapped for almost a year, should we leave it up?

If so, we can add the Bug label so we don't have to fight stale bot.

The Stale label is being removed automatically because some activity has occurred or because the developers have decided that this pull request is important and should not continue to be overlooked.

Sure. I think we should definitely keep the issue, because all those warnings are really annoying and should be fixed.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Replaced by #6750

Was this page helpful?
0 / 5 - 0 ratings