Lorawan-stack: "Special" password character set is non-extensive and opaque for the user

Created on 22 Aug 2019  路  2Comments  路  Source: TheThingsNetwork/lorawan-stack

Summary

"Special" password character set is non-extensive and, worst of all, opaque for the user.

https://github.com/TheThingsNetwork/lorawan-stack/blob/7b6050dba6ca1bb546f90570c23402cb059ca0ba/pkg/identityserver/user_registry.go#L84

Steps to Reproduce

  1. Go to any v3 deployment
  2. Attempt to create an account with password
mtMp`2mhbtytvsN?)`Zf(W/]

What do you see now?

Should contain at least one special character error and a major confusion

What do you want to see instead?

Successful creation of account or at least error message stating which characters stack expects to be present in the password as "special".

Environment

Any

How do you propose to implement this?

Either the "special" password character set should be extended, or the "special" character set should be defined clearly, such that users know, which characters we consider "special".

Can you do this yourself and submit a Pull Request?

yes

bug identity server

Most helpful comment

As I commented on Slack yesterday:

Let's redefine that "special char" category to:

  • Any char smaller than 0
  • Any char between 9 and A
  • Any char between Z and a
  • Any char larger than z

All 2 comments

As I commented on Slack yesterday:

Let's redefine that "special char" category to:

  • Any char smaller than 0
  • Any char between 9 and A
  • Any char between Z and a
  • Any char larger than z
  • Any char smaller than 0

If we start doing numeric char comparison, then I'd suggest "Any char between (space) and 0.

Chars under 0x20 are non-printable and space itself is quite confusing as a "special char", but we could allow it as such.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

kschiffer picture kschiffer  路  4Comments

johanstokking picture johanstokking  路  8Comments

ecities picture ecities  路  5Comments

adriansmares picture adriansmares  路  9Comments

kschiffer picture kschiffer  路  6Comments