Loopback: documentation does not show that disableRemoteMethod is deprecated

Created on 13 Dec 2016 · 9Comments · Source: strongloop/loopback

Bug or feature request

[ X] Bug
[ ] Feature request

Description of feature (or steps to reproduce if bug)

Documentation for disableRemoteMethod does not indicate that this method is deprecated.

Link to sample repo to reproduce issue (if bug)

Expected result

Actual result (if bug)

Additional information (Node.js version, LoopBack version, etc)

In both LB 2 and 3 docs.

bug doc

Source

emckean

All 9 comments

I was not aware of this...Why do you think it's deprecated?

Is it because https://loopback.io/doc/en/lb3/3.0-Release-Notes.html#clean-up-of-api-for-finding-and-disabling-remote-methods says to use disableMethodByName()
?

crandmck on 13 Dec 2016

👍1

@bajtos Can you confirm that disableMethodByname() is deprecated? If so, is it for 3.0 only or both 2.x and 3.0?

crandmck on 14 Dec 2016

Hi -- I was going by this line 439

emckean on 14 Dec 2016

👍1

OK this should be added to the API docs as well. But my question to @bajtos stands: just for 3.0?

crandmck on 14 Dec 2016

As part of the work on the above change, add new SharedClass methods findMethodByName and disableMethodByName in both 2.x and 3.0. The old methods find and disableMethod are deprecated in 3.0.

from https://strongloop.com/strongblog/coming-soon-loopback-3-0/

ritch on 20 Dec 2016

just for 3.0?

Yes, only for 3.0, as was described in the "coming-soon" blog post.

See lib/model.js in the 2.x branch.

bajtos on 21 Dec 2016

Updated in loopback.io docs. Need to update API docs also.

crandmck on 23 Jan 2017

API docs are now updated: http://apidocs.strongloop.com/loopback/#model-disableremotemethodbyname

crandmck on 31 Jan 2017

@crandmck fwiw, I think API docs have regressed, I can't see any note in there about disableRemoteMethod being deprecated, despite the logging message still being in current source.