Lokomotive: Docs required for special_address in metallb component
Currenly in configuration example we are showing use for special_addresses but there is not refrence to it in attribute-reference table. We need to document it.
knrt10
All 9 comments
Can we say this is fixed by https://github.com/kinvolk/lokomotive/commit/173e517e482b964dfd943316971e4294b1723e41#diff-32657cb248d48ce75b8dd96cac5450b3R88?
knrt10
on 29 Jun 2020
Personally, I still do not understand what this option is doing and how to use it, so I'd say we should improve that still.
invidian
on 29 Jun 2020
@ipochi @surajssd any ideas?
knrt10
on 29 Jun 2020
I think thats a map key/value field. Doesn't have any special meaning to it.
ipochi
on 29 Jun 2020
To rephrase, as a user, under what conditions I should care to set special_addresses to something? And to what?
invidian
on 29 Jun 2020
@johananl Does having the key default or special_addresses carry a special meaning in metallb ?
ipochi
on 29 Jun 2020
Nope, these are likely sample address pool names.
IIRC I've opted for using a map for specifying address pools because each pool has a name and an array of prefixes, hence map[string][]string.
johananl
on 29 Jun 2020
If these names are confusing, please feel free to change them to something more intuitive.
johananl
on 29 Jun 2020
johananl
on 22 Sep 2020
Related issues
jbanety
路
6Comments
invidian
路
8Comments
ipochi
路
6Comments
invidian
路
7Comments
rata
路
7Comments
Most helpful comment
Nope, these are likely sample address pool names.
IIRC I've opted for using a map for specifying address pools because each pool has a name and an array of prefixes, hence
map[string][]string.