Loki: Add default value for loki/promail

Created on 8 Oct 2019  路  7Comments  路  Source: grafana/loki

Built loki binary file with master HEAD commit, run below cmd:

 ./loki -server.http-listen-port 3100 -server.http-listen-host localhost
level=info ts=2019-10-08T01:33:38.130165721Z caller=loki.go:125 msg=initialising module=server
level=info ts=2019-10-08T01:33:38.130678565Z caller=server.go:121 http=127.0.0.1:3100 grpc=[::]:9095 msg="server listening on addresses"
level=info ts=2019-10-08T01:33:38.131111781Z caller=loki.go:125 msg=initialising module=overrides
level=info ts=2019-10-08T01:33:38.131144879Z caller=override.go:53 msg="per-tenant overrides disabled"
level=info ts=2019-10-08T01:33:38.131172672Z caller=loki.go:125 msg=initialising module=table-manager
level=error ts=2019-10-08T01:33:38.131201345Z caller=main.go:65 msg="error initialising loki" err="error initialising module: table-manager: Must set -dynamodb.url in aws mode"

The root reason is that some config like tablemanager does not have default value.

@slim-bean @cyriltovena if needed, i would like to do this.

stale

Most helpful comment

I agree with @sh0rez about the difficulty of this. Perhaps the default config (i.e., when no config file is provided) should be a single-binary Loki with local storage for quick demoing/evaluation. I don't think it's going to be possible to provide a _useful_ config by default without making too many assumptions about a user's environment, though.

All 7 comments

Also, need to document which value must set i think.

The thing here seems to be that this is very environment specific, IE Dynamo on Aws but Bigtable on Gcp.

It would be hard to find a default that fits all so it might be better to improve the error message instead

Yep, so need to discuss which parts of config can use default and which must be set by users.

I agree with @sh0rez about the difficulty of this. Perhaps the default config (i.e., when no config file is provided) should be a single-binary Loki with local storage for quick demoing/evaluation. I don't think it's going to be possible to provide a _useful_ config by default without making too many assumptions about a user's environment, though.

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@rfratto @sh0rez any new about this?

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

naughtyGitCat picture naughtyGitCat  路  3Comments

ghostsquad picture ghostsquad  路  3Comments

SuperQ picture SuperQ  路  5Comments

oleksandr-hyuna picture oleksandr-hyuna  路  4Comments

bzon picture bzon  路  5Comments