Logrus: v1.1.0 breaks cross-compiling for solaris

[prymitive]

https://travis-ci.com/prymitive/karma/jobs/149295747#L593-L594

2018/10/02 20:50:53 fatal: There was an error! goos='solaris' goarch='amd64' err='exit status 2' stdout='' stderr='# github.com/prymitive/karma/vendor/github.com/sirupsen/logrus
vendor/github.com/sirupsen/logrus/text_formatter.go:87:4: undefined: initTerminal

It looks like there were some changes around terminal_*.go between 1.0.6 and 1.1.0 that might cause it. What I'm not so sure about is whenever solaris should be covered by terminal_linux.go or terminal_bsd.go. Also looking at build tags I think terminal_linux.go should be the default file since it has // +build !appengine,!js. Either way I'm not 100% sure how to fix it so no PR.

[dgsb]

That's annoying, the file terminal_linux.go is skipped in the solaris build due to its name containing the linux os name

[dgsb]

I've just merged a fix on master trying to clean up all the build constraints which does not seem make any sense anymore today. Can you check if that fixes you issue ?

[prymitive]

Sure, I'll try cross-compiling locally with master and report back. Thanks

[prymitive]

Updated Gopkg to use latest master:

diff --git a/Gopkg.lock b/Gopkg.lock
index 1c82e7e..dff5e95 100644
--- a/Gopkg.lock
+++ b/Gopkg.lock
@@ -161,6 +161,14 @@
   revision = "1624edc4454b8682399def8740d46db5e4362ba4"
   version = "v1.1.5"

+[[projects]]
+  digest = "1:0a69a1c0db3591fcefb47f115b224592c8dfa4368b7ba9fae509d5e16cdc95c8"
+  name = "github.com/konsorten/go-windows-terminal-sequences"
+  packages = ["."]
+  pruneopts = "UT"
+  revision = "5c8c8bd35d3832f5d134ae1e1e375b69a4d25242"
+  version = "v1.0.1"
+
 [[projects]]
   digest = "1:c568d7727aa262c32bdf8a3f7db83614f7af0ed661474b24588de635c20024c7"
   name = "github.com/magiconair/properties"
@@ -294,12 +302,12 @@
   revision = "418d78d0b9a7b7de3a6bbc8a23def624cc977bb2"

 [[projects]]
-  digest = "1:d867dfa6751c8d7a435821ad3b736310c2ed68945d05b50fb9d23aee0540c8cc"
+  branch = "master"
+  digest = "1:1663c5919c78b509aa07a7ca704fa0428ad519f6cf1a9983bc2e5c00a247fd3c"
   name = "github.com/sirupsen/logrus"
   packages = ["."]
   pruneopts = "UT"
-  revision = "3e01752db0189b9157070a0e1668a620f9a85da2"
-  version = "v1.0.6"
+  revision = "3f90cee1e41a38ba27c831844c002952512997c0"

 [[projects]]
   digest = "1:6a4a11ba764a56d2758899ec6f3848d24698d48442ebce85ee7a3f63284526cd"
diff --git a/Gopkg.toml b/Gopkg.toml
index 7909891..755135c 100644
--- a/Gopkg.toml
+++ b/Gopkg.toml
@@ -87,7 +87,7 @@

 [[constraint]]
   name = "github.com/sirupsen/logrus"
-  version = "1.0.6"
+  branch = "master"

 [[constraint]]
   name = "github.com/spf13/pflag"

Double checked that it uses the correct commit -
3f90cee1e41a38ba27c831844c002952512997c0

It got compiled correctly for all targets - https://travis-ci.com/prymitive/karma/jobs/150154366#L566-L588
Looks very much fixed, thanks!

[dgsb]

I'll release a new label soon so that you don't need to depend on an unlock version. I'll keep this issue until this is done.

[dgsb]

@prymitive v1.1.1 has been relased, I'm closing this issue