Lnpopupcontroller: Labels' frames in RTL

[amosavian]

Hi,

Labels are rendered on artwork when I set language to a right to left language.

[LeoNatan]

Hi, thanks for opening this issue. I will be traveling to WWDC and will take a week of vacation after. I will look at this when I am back.

[amosavian]

@LeoNatan Hi, Any chance to get this fixed?

[LeoNatan]

I will take a look.

[amosavian]

I found the problem. Replace this line:

https://github.com/LeoNatan/LNPopupController/blob/master/LNPopupController/LNPopupController/Private/LNPopupBar.m#L708

with this code:

    UIUserInterfaceLayoutDirection layoutDirection = [UIView userInterfaceLayoutDirectionForSemanticContentAttribute:self.semanticContentAttribute];
    if(layoutDirection == UIUserInterfaceLayoutDirectionLeftToRight)
    {
        titleInsets->right += width;
    }

[amosavian]

My snippet lacks proper left (between buttons and labels) inset.

[LeoNatan]

It's more complex than that. I have already fixed it.

[amosavian]

Thanks very much, it's fixed now.