Lnpopupcontroller: customBarViewController is nil after dismissPopupBar but still retained by LNPopupBar

[antiraum]

I'm setting a customBarViewController like this:

let popupBarVC = PopupBarViewController()
let contentVC = PopupContentViewController()

popupBar.customBarViewController = popupBarVC

presentPopupBar(withContentViewController: contentVC, openPopup: true, animated: true, completion: nil)

when I'm dismissing the popupBar the customBarViewController property becomes nil

// popupBar.customBarViewController is still set here

dismissPopupBar(animated: true) {
    // self.popupBar.customBarViewController is nil here
}

However the PopupBarViewController instance is not deallocated and according to Xcode's Memory Graph Debugger it is still retained by an instance of LNPopupBar.

If I repeat to present and dismiss the popupBar like this I accumulate instances of PopupBarViewController that are all retained by different instances of LNPopupBar.

If I keep a reference to the PopupBarViewController instance myself and reuse that to set it to the popupBar.customBarViewController property everytime I'm going to present the popupBar, the PopupBarViewController instance will be retained by many LNPopupBar instances.

Seems to me that LNPopupBar instances are not released when they should be (after dismissPopupBar).

I'm using
LNPopupController v2.5.10
Xcode 9.2

[LeoNatan]

Thank you for the great report!
I will look into this ASAP.

[LeoNatan]

Considering how the system works, the popup bar itself is created on demand and only released when the presenting controller is released. This is to allow, for example, customization done by the user to persist between presentations.

I do however see a problem where cleanup should be performed after dismissing the popup.

[antiraum]

It would be fine for me if the popup bar is not released until the presenting view controller is released. But it seems a new popup bar instance is created on every present.

[LeoNatan]

Only one bar should be created per presenting controller.

[LeoNatan]

Yes, I see what you mean. Investigating

[LeoNatan]

//No longer need to retain the popup controller after dismissing.
objc_setAssociatedObject(self, _LNPopupControllerKey, nil, OBJC_ASSOCIATION_RETAIN_NONATOMIC);

Well that about will do it 😆

[LeoNatan]

OK, found a leak that caused previous bars to remain in memory.

But I still think the correct behavior of the system should be to only release the bar upon the presentation controller release.

[LeoNatan]

Please try now with 2.5.11.

Thanks

[antiraum]

fix confirmed. thanks!