Lnd: subscribetransactions fires duplicated event when a transaction is received

[joaodealmeida]

Background

subscribetransactions is firing 2 events per tx received. Whenever I receive a transaction, lnd fires 2 events containing the same payload.

The transaction gets notified independent from the block notification once it’s confirmed and it’s also notified when processing the block notification containing the transaction.

Your environment

• version of lnd - 0.5.1-beta commit=v0.5.1-beta-dirty
• which operating system (uname -a on *Nix) - Linux ip-172-31-4-119 4.4.0-1060-aws #69-Ubuntu SMP Sun May 20 13:42:07 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
• version of btcd, bitcoind, or other backend - bitcoind

Steps to reproduce

• Listen suscribetransactions
• Generate an address
• Send btc to that address

Expected behaviour

An event should be fired only when the transaction gets notified independent from the block notification once it’s confirmed.

Actual behaviour

An event is also fired when processing the block notification containing the transaction.

[Roasbeef]

I think this is no longer the case for updates from the invoice RPC sub-server.

[wpaulino]

This is regarding wallet transaction notifications.

[nicolasburtey]

I can confirm the issue is still present