Lmms: PluginBrowser: Tree layout and search bar

[JohannesLorenz]

This is a begginer task to prepare our plugin browser for LV2 (and the new layout). The following proposals are conforming to @budislav 's design and also favored by multiple LMMS devs. They were discussed in #4733 .

Current look

<filter search bar>
bit invader
triple oscillator
zynaddsubfx
...

Changes

• It should have a new search bar (like EffectSelectDialog)
• The PluginDescWidgets should be in a tree layout.

Aside from that, everything should stay like it is, i.e. keep the plugin names and the logos.

You should only create two top level items by now: LMMS and LV2. Move all current plugins to LMMS, leave LV2 empty.

<filter search bar>
LMMS
|- bit invader
|- triple oscillator
|- zynaddsubfx
|- ...
LV2

Where to get started?

Code

include/PluginBrowser.h
src/gui/PluginBrowser.cpp

Links

E.g. (but you may find better ones):

• How to add QPushButton or widgets to a QTreeWidget as QTreeWidgetItem
• QTreeViewFilter

Git

Open a new branch, push to your remote and make a pull request.

[fschuelke]

is this still open? I could try to work on the ticket

[JohannesLorenz]

@itlives As no one else asked to work on it, I'd consider it still open. Your work on this issue would be appreciated.

[fschuelke]

@JohannesLorenz i will try my best, still pretty new to the whole thing but ill take it as a challenge. Will get help if needed

[JohannesLorenz]

@itlives Sure, just ask on discord if you have questions.

[fschuelke]

@JohannesLorenz you might want to edit the suggested filepath to src/gui/PluginBrowser.cpp ;)

[fschuelke]

@JohannesLorenz i am now working on the issue. Should the search bar act like a filter or a sorter? (only display matching plugins OR show matching plugins on top)

[JohannesLorenz]

@itlives I'd prefer a filter, that would also be conforming to what we have in EffectSelectDialog (when you add an effect somewhere and are asked to choose one).

Though that's just my opinion. @tresf What would you say?

[tresf]

Should the search bar act like a filter or a sorter? (only display matching plugins OR show matching plugins on top)

@itlives I'd prefer a filter[...] @tresf What would you say?

Agreed.

[JohannesLorenz]

@itlives How is it going? If there is anything you need help with, just let us know.

[fschuelke]

@itlives How is it going? If there is anything you need help with, just let us know.

@JohannesLorenz
Hello,
I am sorry to say that I am busy with my job and my music and therefore have to cancel my plans on working on LMMS. Wish you the best for the future.

[JohannesLorenz]

@itlives Np. If you have anything unfinished we could use, feel free to send us a link to your branch.

At all: this issue is available again.

[ghost]

Ok I'll bite :-)

[ghost]

I’ve made a branch here https://github.com/CYBERDEViLNL/lmms/tree/master_dev

Should I create a PR against the lv2 branch?

[JohannesLorenz]

Great :+1:

Can you please make a PR against master? I'd say let's do Lv2 later.

Two things that I saw already:

• Lv2 instruments will also be loaded in addNativePlugins, which is why
  
  
  
  • I'd remove the "native" from the function name
  
  
  • it should have some code like around line 178 in the cpp file
  
  

for (const PluginKey& key : pluginKeys)
{
if(key.desc->name == "lv2instrument")
  // somehow add to m_lv2Root
else
  // somehow add to m_lmmsRoot
}

• PluginDescList got unused in your code. You can remove the class from the header.

[ghost]

Good :-)

Thanks for the review, I’d made some changes and opened a PR here https://github.com/LMMS/lmms/pull/4923

[JohannesLorenz]

Many thanks @CYBERDEViLNL :rocket:

Can you please make a 2nd PR from your branch to branch lv2-review on remote https://github.com/JohannesLorenz/lmms.git?

[ghost]

OK, NP glad I could help :-)

Done :+1:

[JohannesLorenz]

Just wanted to post an image how it looks like :smile:

[JohannesLorenz]

Already closed in April (!) in #4923 . Closing :smile: