Lmms: Translation in Swedish displays % character in menu

[saurid]

Menu option "View" in swedish shows "%Visa" instead of the correct "Visa". Windows 10 version 1.2.0-rc6

[PhysSong]

I guess it should be &Visa. Ampersands are used for accelerator keys.

[saurid]

Seems like it, yes. Alt-V is not working for this menu option, but does work for the other ones.

[zonkmachine]

I suggested a fix for this on Transifex but couldn't push it as I don't seem to be cool enough to do this. I just glanced over the Swedish translation and it looks like people have been pushing changes online without testing it against lmms.

[PhysSong]

For 1.2, it'd be sufficient to edit sv.ts.

[zonkmachine]

Translations won't be merged back from transifex before 1.2?

[Spekular]

I fixed it on transifex FWIW. Couldn't seem to select zonk's translation so it's credited to me now? I don't entirely get transifex.

[zonkmachine]

OK. I resolved the Transifex issue.

[SecondFlight]

Can this be closed then?

[zonkmachine]

I'd like to know how changes are merged back to 1.2 first. I'm a total noob at Transifex.

[PhysSong]

Editing this part should work:
https://github.com/LMMS/lmms/blob/2f19fa11c886374adcc74990e52d3ed0473fbf08/data/locale/sv.ts#L3941-L3942
Though not directly related, I also found one place where accelerator is missing:
https://github.com/LMMS/lmms/blob/2f19fa11c886374adcc74990e52d3ed0473fbf08/data/locale/sv.ts#L306-L307

[zonkmachine]

Yes, but isn't the translations going to be merged back from Transifex?

[PhysSong]

IIRC Transifex is synced with master now. @liushuyu Is it correct?

[Spekular]

Updated the "Copy Value" translation to "&Kopiera värde (%1%2)" on Transifex as well. I was unsure about that earlier since it changes the accelerator key, but I guess it's better than not having one at all.

[PhysSong]

i18n strings in stable-1.2 have never been updated since 9 May 2017 so I fixed it manually in 1bae047b98558981c20c85edc44550f4aa9714d9.