Lmms: LMMS supports buffersize of 32 samples, but GUI only goes to 64

[JohannesLorenz]

The ruler for the buffersize is in "Edit -> Settings -> General Settings". It should go down to 32, not 64. It should still be possible to set the old values.

As @tresf has already pointed out, this can be fixed in src/gui/SetupDialog.cpp.

A simple beginner issue, but not trivial.
Not urgent, as the settings can be adjusted with a text editor.

[amelenty]

hi, is it fine if I try to do this?

[zonkmachine]

@amelenty Absolutely! I don't think anyone is working on this at the moment so go ahead.

[amelenty]

@zonkmachine

Got a question about implementation of this.

Please take a look at this function setBufferSize() in the file you mentioned.

Basically each position _x_ on the slider corresponds to _64x_ buffersize option, so currently each selected option must be a multiple of 64. I'm not sure how to make 32 work.

My best guess now is to change slider ticks/range/etc for _x_ slider value to correspond to _32x_ buffersize and provide a workaround for 64+ buffersizes to be rounded to nearest 64 multiple (similar to rounding to 256 multiples that occurs after 256 in the function I mentioned earlier).

Will that be fine? Sorry if my question is dumb.

P.S. I'd also like to add some comments that explain what's going on there

[JohannesLorenz]

@amelenty Thanks for trying this issue.

I would use 32 as the general step size (which should allow 32 as a minimum?). A buffer size of 64+32 should be acceptable, too.

On the other side, for cleaning up, I would limit the range to 4096:

• I experienced crashes with zyn with a buffer size > 4096
• Honestly, who uses such large buffer sizes? :smile:

[Sawuare]

On the other side, for cleaning up, I would limit the range to 4096

• I experienced crashes with zyn with a buffer size > 4096
• Honestly, who uses such large buffer sizes? 😄

I agree, but I think we should limit it to 2048. That's sufficient, isn't it? And most DAWs have that as the limit. Check this small poll that I created on our Discord.

[JohannesLorenz]

@Sawuare Doesn't this poll say that 40% of users use a buffer size > 2048?

[Sawuare]

@JohannesLorenz It does, but I doubt they need to.

[amelenty]

I found some info on buffer size on this page.

Apparently. small buffer size (up to 256) is good for recording and making real-time changes to tracks, while large buffer sizes are good for lots of non-realtime processing.

I honestly have no idea about how high the upper limit should be.

[JohannesLorenz]

@amelenty We're sorry, but someone else already committed a fix meanwhile: #4336 . Thanks for trying, anyways :1st_place_medal:

[DouglasDGI]

I'm assuming the merge of #4336 resolves this issue. I'll close this now, let me know if it's a mistake.