Lmms: BUG: The "Info" button does not work with the Controller Rack button in the 2nd row

[raindropsfromsky]

The "i" button does not work with the Controller Rack button in the 2nd row.
(It works with all 6 other buttons. Thus, technically this is a bug, but not worth much.)

In any case the "Info" button seems to be redundant: It does not add any value!
It just shows a tooltip when the mouse is hovered over buttons.
Well, that same tooltip is shown even without clicking on this button first!

It does not work on the other elements of the screen, either. So I guess that it is yet to be implemented fully (?) If so, a suggestion: When the user clicks on the "i" button first, let LMMS show an extended tooltip instead of normal (short) tooltip.

[PhysSong]

Could you add a screenshot for this issue?

[raindropsfromsky]

Well, as the examples below show, there is no consistency in results:

1. In some controls, there is a ban symbol, and no tooltip.
2. In others, there is a ban symbol, but the tooltip is displayed.
3. In yet others, there is a "?" overlay (instead of the "banned!" icon), and a tooltip is shown

The tooltip is shown even without clicking on the "i" button, so apparently it adds no value.

After clicking on "i" button:

Without clicking on "i" button:

(The only difference is the "?" overlay on the mouse-pointer.)

After clicking on "i" button:

(Note that despite the banned symbol, the tooltip is shown anyway!)

Without clicking on "i" button:

(Tooltip is shown.)

After clicking on "i" button:

(Banned symbol, and no tooltip.)

After clicking on "i" button:

(Banned symbol, and no tooltip.)

After clicking on "i" button:

(Banned symbol, and no tooltip.)

After clicking on "i" button:

(Despite the banned symbol, the tooltip is shown anyway!)

[raindropsfromsky]

BTW there is yet another problem:
Normally, after clicking on the "i" button, we can hover the mouse over multiple controls, and it goes on showing their tooltips. But if I hover over the "notes" area, and then move the mouse _out_ of the "notes" area, LMMS quits the info mode automatically.

There may be other controls that behave in this way.

[Sawuare]

I think we should remove the What's this? system because it's not fully implemented and has bugs.
Tooltips and documentation would be sufficient for teaching users.

[tresf]

I think we should remove the What's this? system because it's not fully implemented and has bugs.
Tooltips and documentation would be sufficient for teaching users.

I wholeheartedly agree with this. Outside of LMMS, I've never used a help system like this before.

[Sawuare]

I will remove it. What branch should I target, master or stable-1.2?

[tresf]

@Sawuare it should be properly discussed I think, but master.

[Sawuare]

@tresf What aspect should be discussed? 🤔

Some info:
On master, searching for WhatsThis gives 121 results in 19 files, mostly setWhatsThis() and QWhatsThis::showText() (99 translatable strings), and some code for the functionality itself and its toolbar button.
Edit: The numbers above represent searching in src. When searching in include and plugins, the total numbers are much higher.

[tresf]

@Sawuare, it's something that we should run past the #devtalk channel first I think.

[Sawuare]

Fixed via #4128.