Lmms: If "Sinc Medium" is (recommended) why isn't it default?

Created on 8 Oct 2016  路  9Comments  路  Source: LMMS/lmms

The Export Track dialog tells us "sinc medium" is "(recommended)". If it's recommended, why isn't it the default?

screen shot 2016-10-08 at 2 43 19 pm

enhancement

All 9 comments

I wholeheartedly agree. Also, why can't preferred export settings be set/saved?

It's sinc, not sync. I think it's this function: https://en.wikipedia.org/wiki/Lanczos_resampling
It could also be that the (recommended) comment was put on the wrong option.

The article sites 2 as being the best compromise. I don't think it's mislabeled.

(with a = 2) the "best compromise in terms of reduction of aliasing, sharpness, and minimal ringing"

Probably just enough to change <number>1</number> to <number>2</number> here:
https://github.com/LMMS/lmms/blob/48cc3bb5ef85bac8cc7c01b11dd3139c547a0677/src/gui/dialogs/export_project.ui#L239

I'd make this change if I knew how to, but I have no idea what branch etc. Could someone change that one digit in the code and close this issue, please? :)

I knew how to, but I have no idea what branch etc.

Well, isn't this issue a perfect one for you or someone else to familiarize with git? We have extencive documentation on how to submit patches and how to use branches:
https://github.com/LMMS/lmms/wiki/Accessing-git-repository
https://github.com/LMMS/lmms/wiki/Submitting-a-patch

I plan on making a git cheatsheet kind of thing on the wiki, to help all of you people out.

Maybe we should have a bitesize issue label?

@unfa If you want to apply the change I suggested just go ahead. You need to do it from the current master.

Could someone change that one digit in the code and close this issue, please? :)

OK. Fixed it! :wink:

Thanks @zonkmachine !!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

DomClark picture DomClark  路  3Comments

Firepal picture Firepal  路  3Comments

Andrewer11 picture Andrewer11  路  3Comments

binyominzeev picture binyominzeev  路  3Comments

softrabbit picture softrabbit  路  3Comments