Live-share: [VS Code] Parser of shared server URL has trouble with parentheses

Created on 24 Feb 2019  路  4Comments  路  Source: MicrosoftDocs/live-share

Product and Version [VS/VSCode]: VSCode
OS Version [macOS/Windows]: Windows
Live Share Extension Version: 0.3.1225
Target Platform or Language [e.g. Node.js]: N/A

Steps to Reproduce / Scenario:

  1. Start a live sharing session.
  2. Start a python HTTP server.
$ python3 -m  http.server
Serving HTTP on 0.0.0.0 port 8000 (http://0.0.0.0:8000/) ...
127.0.0.1 - - [23/Feb/2019 17:05:48] code 404, message File not found
127.0.0.1 - - [23/Feb/2019 17:05:48] "GET /) HTTP/1.1" 404 -

On the client, VSCode will open the path /)in the browser, most likely because it failed to parse the URL surrounded by parentheses in the terminal output.

port sharing bug vscode

All 4 comments

@dalloriam Thanks for reporting this! Yeah you're right, our URL parsing is incorrectly including the trailing parentheses in the path it shares. Just to confirm: if the guest removes the trailing parentheses, does the shared server load correctly?

@lostintangent Yep! Everything works great for the guest once the path is corrected.

@dalloriam OK great, thanks for confirming that! We鈥檒l try to get this resolved soon. We had done testing with Django and Flask, but we obviously missed this specific scenario 馃榿

This issue has been closed due lack of any recent activity. We've made lots of improvements to Live Share since this issue. Please re-open the issue, if this problem persists.
馃Live-Share-Clean-Up-Bot馃

Was this page helpful?
0 / 5 - 0 ratings