Live-share: Show GitHub login instead of email address in notifications

[fodil-a]

Hi,

Product and Version [VS/VSCode]:
VSCode Version 1.24.0-insider Commit 25aab64fccf650e2be3d19d613e51b26100300a8 Date 2018-05-10T05:16:09.756Z Shell 1.7.12 Renderer 58.0.3029.110 Node 7.9.0 Architecture x64
OS Version [macOS/Windows]: Windows 10 Pro
Live Share Extension Version: 0.3.98
Target Platform or Language : Haskell (but any langage is good)

Steps to Reproduce / Scenario:
You need 2 VSCode running, one with any account, you can use the same account on both.
You just need one with a github account. (not tested with a LiveShare account)

1. Connect with live-share on VSCode with a github account.
2. Change settings to always have "host approval". (with "liveshare.guestApprovalRequired": true)
3. Connect with another VSCode session.
4. Go on host VSCode, and here is the issue.

Expected: email address hidden (or control over it) on host approval.
Got: email address is displayed on host approval.

[Chuxel]

@AFodil Thanks for raising the issue. This is in fact a security feature we've put in place to ensure the host can easily verify that the person that is joining is in fact who they say they are. (Name alone does not give you that confidence.)

That said, what kind of scenario were you thinking about where you are collaborating with someone that you would not want to see the email address? Is there something else you would have in mind to give the host confidence that the guest is who they say they are?

[fodil-a]

Hi @Chuxel

Use case: when I want to help someone (from a dev community), I don't want to share my email with that person.

Possible solutions:

• username or link to github account,
• link to VS Live Share account (if exists),
• having an option to hide email, warning the host.

[Chuxel]

@AFodil Using the GitHub login should meet the need without increasing security risks, so I've updated this issue to be a feature request along these lines.

Note that we also have a GitHub issue on anonymous access you can up-vote: #3. However, that would be something the host would need to explicitly allow, so the GitHub login option is likely to be better for most scenarios.

[m4xc4v413r4]

Yes, I thinking that if we're logged in with the Github account and we have the email hidden on our Github account, showing it on VS Live kind of defeats the purpose.

[xmsid]

are there any updates on this?
showing something like github.com/{username} instead of the email is much better, and the commit for adding this feature won't be hard to do, just simply pass the string in that format instead of the email

[xmsid]

Something like:

If the user was using github as a login way

[lostintangent]

This has been resolved in the latest release 🚀 Thanks again for the feedback!