Live-share: [VS Code] Did not prompt sign-in from user who was invited to session

[zecuria]

Error:

Did not request sign-in from user joining the session.

Product and Version [VSCode]: 1.21.1
OS Version [Windows]: 10
Live Share Extension Version: 0.2.260
Target Platform or Language [e.g. Node.js]: React.js

Steps to Reproduce / Scenario:

1. Share session link with a co-worker who is not signed into Live Share Plugin
2. The co-woker will open the link in chrome
3. They click on the link and open it in VSCode
4. It will open a new VSCode session and present an empty window as the Co worker is not signed into the Plugin

Details

I went through the documentation with my co-worker and the documentation for the owner provided here:

4. Send someone the invite link

However that does not specify that the user requires to be signed in, it even says that they do not need to be signed up which we assumed meant that it would work out the box. We then looked into the Joiner documentation here:

4. Sign in from within your IDE/editor

The details of the documentation said the following: "To let other collaborators know who you are, you may be asked to sign in during the join process". However the co-worker was never prompted or asked to sign in and was just presented with an empty VSCode window.

When the co worker signed in the Live Session worked perfectly but it was an unnecessarily confusing and perhaps we misunderstood the meaning of the documentation, or the documentations should be further clarified.

[Chuxel]

Hey @zecuria - Thanks for reporting this. They should indeed be prompted to sign in. This may be the same as #89. What we have recently noticed is that in certain circumstances if someone clicks to join a collaboration session before Live Share has completed the installation process (denoted by "Finishing the Live Share Installation" in the status bar), we sometimes loose the fact that VS Code was started up with a link.

Do you know if the guest joined prior to the step completing? For example, reloading after extension install and then immediately clicking on the link or simply shutting VS Code down without a reload.

[zecuria]

I can confirm that they had completed the installation process as after installing and restarting they also updated their VSCode version twice from 1.19.3 > 1.21.0 > 1.21.1 and only after confirming that they had no updates remaining did they click on the link.

They restarted VSCode multiple times and attempting to join the session however it did not work. And they were just presented with a blank screen each time. Until they logged after which it worked correctly.

[Chuxel]

@zecuria Very interesting. We'd love to get a look at their logs. Could you have the guest run the "Live Share: Export Logs" command and either just drag-and-drop the zip into a comment here or email them to [email protected]?

[zecuria]

This the log file:

log.zip

Hopefully that helps

[Chuxel]

@zecuria Thanks very much! We'll take a look.

[codycraven]

My co-worker (#179) experienced the same thing today.

[Chuxel]

@codycraven Thanks! We've confirmed this is a bug and are working on a fix.

[Chuxel]

We just released v0.2.399 that should resolve this issue! Let us know if it is still happening for you.