Litho: Support targetSDK 28 - cashing on app launch

Created on 18 Dec 2018  路  10Comments  路  Source: facebook/litho

Version

// Litho
implementation 'com.facebook.litho:litho-core:0.22.0'
implementation 'com.facebook.litho:litho-widget:0.22.0'
compileOnly 'com.facebook.litho:litho-annotations:0.22.0'

kapt 'com.facebook.litho:litho-processor:0.22.0'

// SoLoader
implementation 'com.facebook.soloader:soloader:0.5.1'

// For testing
testImplementation 'com.facebook.litho:litho-testing:0.22.0'

Issues and Steps to Reproduce

Build and run on api level 28

Expected Behavior

Not crashing

stacktrace.txt

Most helpful comment

FYI: The issue was fixed in v0.25.0 release.

All 10 comments

it works fine with 0.21.0

cc @sergeynv

Same stacktrack log as me. I have crash issue only on my google pixel 3 XL device with android 9 version. Other android version is fine. Please check it. Thanks

Having the same issue only on Android 9.0 and Litho version 0.20.0. I don't know how it could be related but after testing out it looks like this is somehow Android Studio 3.3 problem because after checking out commit which was previously completely working now has this issue.

@cezium Please add part of the error message to the title and/or include a portion of the stack trace in the description to save others some time. I almost opened a duplicate issue for this because stacktrace.txt is not searchable.

Litho started calling RenderNode's setTranslationX(F)Z and setTranslationY(F)Z methods in c16a40c3d6. And it seems these methods are blacklisted when targeting Android P. At least I can't see them via reflection.

I have the same issue.

Any news about that problem?

FYI: The issue was fixed in v0.25.0 release.

Fixed in de3097b

Was this page helpful?
0 / 5 - 0 ratings