Lit-html: AttributePart and PropertyPart need previous value optimizations

Created on 24 Nov 2017  路  2Comments  路  Source: Polymer/lit-html

The dirty checking that NodePart does for primitive values should be ported to AttributePart and PropertyPart.

picture justinfagnani

Most helpful comment

Something along these lines? https://gist.github.com/kenchris/745f22b7451d3fe56e986965f2cc6d9b

I removed my previous dirty check in lit-html-element and used this instead and it results in a similar speed up:

screenshot from 2017-12-08 15-09-08

If the approach is correct and I understood the code correctly, then I can turn this into a patch

picture kenchris on 8 Dec 2017
👍2

All 2 comments

@QuinntyneBrown please do not ask the same question on several, unrelated issues.

justinfagnani picture justinfagnani on 5 Dec 2017
👍1

Something along these lines? https://gist.github.com/kenchris/745f22b7451d3fe56e986965f2cc6d9b

I removed my previous dirty check in lit-html-element and used this instead and it results in a similar speed up:

screenshot from 2017-12-08 15-09-08

If the approach is correct and I understood the code correctly, then I can turn this into a patch

kenchris picture kenchris on 8 Dec 2017
👍2
Was this page helpful?
0 / 5 - 0 ratings

Related issues

MVSICA-FICTA picture MVSICA-FICTA  路  5Comments
RyanAfrish7 picture RyanAfrish7  路  4Comments
erichiggins picture erichiggins  路  4Comments
pjtatlow picture pjtatlow  路  3Comments
cbelden picture cbelden  路  4Comments