Lit-element: Adding reflectToAttribute to the demo doesn't work

[kenchris]

      static get properties() {
        return {
          foo: String,
          bar: Number,
          whales: { type: Number, reflectToAttribute: true }
        }
      }

whales: 🐳🐳🐳🐳🐳🐳🐳

$0.whales
7
$0.getAttribute("whales")
"0"

[abdonrd]

I think in the Polymer.PropertiesMixin only types are supported.

[kenchris]

Maybe, that is why I didn't examine further. It would be nice to know whether these features are going to be deprecated or just not implemented yet.

[ernsheong]

Default values also don't seem to be supported e.g.

foo: {
  type: String,
  value: "bar",
}

[sorvell]

This is by design. With LitElement we explicitly wanted to make "properties" less powerful and more straightforward.

Property defaults should be set in the standard way, in the constructor. This is generally better for performance.

We also elected not to support observers or reflectToAttribute from PolymerElement instead preferring users to write this pretty standard code explicitly.

[sundar-rajavelu]

Where in a heaven are these documented? I was breaking my head :(

[blikblum]

We also elected not to support observers or reflectToAttribute from PolymerElement instead preferring users to write this pretty standard code explicitly.

Code samples showing how implement those would be helpful

[HitkoDev]

@blikblum Here's how you can implement basic reflection (proof of concept, won't work with inherited properties)

    _shouldRender(props, changedProps, prevProps) {
        Object.keys(changedProps)
            .filter(property => this.constructor.properties[property].reflectToAttribute)
            .forEach(property =>
                this._propertyToAttribute(
                    property,
                    this.constructor.attributeNameForProperty(property),
                    changedProps[property]
                )
            )
        return super._shouldRender(props, changedProps, prevProps)
    }