Lisk-sdk: Missing error handler for updateMemAccounts
https://github.com/LiskHQ/lisk/blob/6cdfef14ebc7afaeb5ae68efcf141e75c7ef2633/modules/loader.js#L487
This block has no .catch handler, which is a reliability issue.
I would have put one there myself, but I don't know what should be the correct error handling logic in that specific case.
vitaly-t
All 2 comments
If something happened wrong in loader, the lisk instance should not start. I believe we should simply return that promise
return library.db.task(updateMemAccounts).then(function (res) {
As we already having a catch on upper level.
https://github.com/LiskHQ/lisk/blob/78ad7092da105ec0a40aed4f25ab46a67657c3c8/modules/loader.js#L510-L513
@4miners and @karmacoma can confirm this logic.
nazarhussain
on 30 Jan 2018
~Whoever takes on this task, please make sure PR-1443 has been merged first, as it does a bit of refactoring on that same piece of code :wink:~
UPDATE: That PR has gone in, now! :wink:
vitaly-t
on 30 Jan 2018
Related issues
yatki
路
3Comments
hendrikhofstadt
路
4Comments
ManuGowda
路
3Comments
ScrewchMcMuffin
路
3Comments
willclarktech
路
4Comments
Most helpful comment
If something happened wrong in loader, the lisk instance should not start. I believe we should simply return that promise
As we already having a
catchon upper level.https://github.com/LiskHQ/lisk/blob/78ad7092da105ec0a40aed4f25ab46a67657c3c8/modules/loader.js#L510-L513
@4miners and @karmacoma can confirm this logic.