Linux: -Wsometimes-uninitialized in drivers/infiniband/sw/rdmavt/cq.c

[nathanchance]

drivers/infiniband/sw/rdmavt/cq.c:260:7: warning: variable 'err' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
                if (err)
                    ^~~
drivers/infiniband/sw/rdmavt/cq.c:310:9: note: uninitialized use occurs here
        return err;
               ^~~
drivers/infiniband/sw/rdmavt/cq.c:260:3: note: remove the 'if' if its condition is always false
                if (err)
                ^~~~~~~~
drivers/infiniband/sw/rdmavt/cq.c:253:7: warning: variable 'err' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
                if (!cq->ip) {
                    ^~~~~~~
drivers/infiniband/sw/rdmavt/cq.c:310:9: note: uninitialized use occurs here
        return err;
               ^~~
drivers/infiniband/sw/rdmavt/cq.c:253:3: note: remove the 'if' if its condition is always false
                if (!cq->ip) {
                ^~~~~~~~~~~~~~
drivers/infiniband/sw/rdmavt/cq.c:211:9: note: initialize the variable 'err' to silence this warning
        int err;
               ^
                = 0
2 warnings generated.

Ah C scoping bugs...

Patch sent: https://lore.kernel.org/lkml/[email protected]/

[nathanchance]

v2 (commit message change only, code still the same): https://lore.kernel.org/lkml/[email protected]/

[nathanchance]

Accepted: https://git.kernel.org/rdma/rdma/c/4d2b8517ba1f3aba9a952ebf153ec972a127c80c

[nathanchance]

Fixed: https://git.kernel.org/next/linux-next/c/4d2b8517ba1f3aba9a952ebf153ec972a127c80c