Linter: lints to promote spread collections

Created on 1 Feb 2019  路  5Comments  路  Source: dart-lang/linter

Placeholder for conversations around lints to promote the use of spread-collections (feature spec, implementation plan).

@munificent: ideally I'd like to see lints discussed/tracked in the implementation plan. Does that sound reasonable? What's the process for updating it? Should I add a discussion to the tracking bug?

/cc @stereotype441 @bwilkerson

help wanted meta new language feature question

Most helpful comment

FWIW, I have a couple of quick assists nearly ready. We should coordinate so that the lints flag the cases the assists can handle.

All 5 comments

Feel free to just send a pull request with the changes to the implementation plan. I'd love to see the linter on there.

FWIW, I have a couple of quick assists nearly ready. We should coordinate so that the lints flag the cases the assists can handle.

Thanks @munificent. https://github.com/dart-lang/language/pull/201 opened.

FWIW, I have a couple of quick assists nearly ready. We should coordinate so that the lints flag the cases the assists can handle.

Fantastic! Does analyzer 0.35.0 have enough support that we can start implementing or do we need to wait for another push?

I'm not entirely certain. I know that it contains the AST changes to represent the new constructs (that's why it was a breaking change), but I think the parser was incomplete at that point. Resolution was, and still is, incomplete, but the assist is primarily syntactic in nature, and I'd guess that the lint would be too.

After some conversations w/ @bwilkerson and @stereotype441, I'm leaning towards a process that mirrors how analyzer and other tools phase their implementations. As a result, closing this in favor of: #1409 and #1410.

Was this page helpful?
0 / 5 - 0 ratings