Linter: `prefer_const_constructors` doesn't take into account implicit creation

Created on 1 Mar 2018  路  6Comments  路  Source: dart-lang/linter

From https://github.com/flutter/flutter/issues/15023, It's likely that prefer_const_constructors doesn't take into account implicit const creation.

flutter
Source
picture devoncarew
👍1

Most helpful comment

Awesome! Thanks for digging into it.

picture devoncarew on 1 Mar 2018
👍2

All 6 comments

Thanks for the report!

I've got this reproduced in the latest Flutter SDK (using linter 0.1.43). Looking now to see if it's been fixed by @a14n's recent work in the area...

pq picture pq on 1 Mar 2018

Confirmed 馃憤 .

Using linter 0.1.43:

image

Using head:

image

I'll look at publishing a new linter in the next few days to get this fix out for integration into the Flutter SDK.

pq picture pq on 1 Mar 2018
🎉1

Awesome! Thanks for digging into it.

devoncarew picture devoncarew on 1 Mar 2018
👍2

I wouldn't have bet it works. :smile:

a14n picture a14n on 2 Mar 2018

@pq thanks for the check.

a14n picture a14n on 2 Mar 2018
👍1

Fixed by @a14n in 0.1.44 馃帀

pq picture pq on 29 Jun 2018
Was this page helpful?
0 / 5 - 0 ratings

Related issues

annagrin picture annagrin  路  3Comments
jelenalecic picture jelenalecic  路  3Comments
toddabel picture toddabel  路  3Comments
pq picture pq  路  3Comments
pasindud picture pasindud  路  4Comments