Lint-staged: listr-update-renderer version is a link

[evgeny-sav]

We are using private npm repository and because of listr-update-renderer's version is a link to github we have failing build.

npm ERR! fetch failed https://github.com/okonet/listr-update-renderer/tarball/upgrade-log-update
npm WARN retry will retry, error on last attempt: Error: unable to get local issuer certificate
npm ERR! code UNABLE_TO_GET_ISSUER_CERT_LOCALLY

Could you please publish this package to public npm and set listr-update-renderer's version not as link.

[AdaskoTheBeAsT]

It is same for people behind corporate proxy - when installing by yarn we receive

yarn install v1.10.1

05-Nov-2018 16:22:39 | [1/4] Resolving packages...
05-Nov-2018 16:22:41 | error An unexpected error occurred: "https://github.com/okonet/listr-update-renderer/tarball/upgrade-log-update: connect ECONNREFUSED 10.254.3.15:443".

[iamstarkov]

=(

[iamstarkov]

@okonet can you publish that repo under your own npm scope?

[okonet]

I could I guess but it's going to take some of my time. If someone else can do it I'm okay to send my PR to its fork.

[iamstarkov]

hm, https://github.com/SamVerschueren/listr-update-renderer/pull/9

[iamstarkov]

hm, I dont see where listr-update-renderer is being used https://github.com/okonet/lint-staged/search?q=listr-update-renderer&type=Code

[iamstarkov]

oh well

[iamstarkov]

~/projects/oss/lint-staged fix/listr-update-renderer
☯ yarn why listr-update-renderer
yarn why v1.12.1
[1/4] 🤔  Why do we have the module "listr-update-renderer"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "[email protected]"
info Reasons this module exists
   - "listr" depends on it
   - Hoisted from "listr#listr-update-renderer"
info Disk size without dependencies: "288KB"
info Disk size with unique dependencies: "516KB"
info Disk size with transitive dependencies: "900KB"
info Number of shared dependencies: 24
✨  Done in 0.59s.

[iamstarkov]

so scoped new version of listr-update-renderer integrated in lint-staged wont help anyway =(

[iamstarkov]

if you have this problem, then publish changes from this PR https://github.com/SamVerschueren/listr-update-renderer/pull/9 as [email protected] and use yarn resolutions in your app, like this:

  "resolutions": {
    "listr-update-renderer": "0.4.1",
  }

run yarn install, problem should be fixed

[iamstarkov]

/cc @evgeny-sav @AdaskoTheBeAsT @mojodna

[iamstarkov]

there are few options we have:

0) publish changes @okonet's changes from PR internally and use yarn locks
1) ask @SamVerschueren to merge https://github.com/SamVerschueren/listr-update-renderer/pull/9, release the change and bump it into listr itself and release
3) ask @okonet to repeat previous point but change both listr and listr-update-renderer to become scoped and use scoped listr in lint-staged
4) last option would be to perhaps investigate how we can avoid a need in a PR https://github.com/SamVerschueren/listr-update-renderer/pull/9

[evgeny-sav]

@iamstarkov I have solved this problem by just installing lint-staged version 7.3.0. there is no dependency on this listr-update-renderer
https://github.com/okonet/lint-staged/blob/v7.3.0/package.json

[okonet]

@iamstarkov any updates on this one? I remember you were working on it.

[albert-olive]

I'm having the same issue with "lint-staged": "8.1.0". When I try to deploy with jenkins I have this error:

error https://github.com/okonet/listr-update-renderer/tarball/upgrade-log-update: Integrity check failed for "listr-update-renderer" (computed integrity doesn't match our records, got "sha1-Bgc/qTFmJ3YHp4FPTh+DlgCBQUw=")
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
Build step 'Execute shell' marked build as failure

It works with: "lint-staged": "8.0.4"

[vieira]

Not sure if related to this ticket, but I am having the same problem as @albert-olive:

yarn install v1.10.1
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
error https://github.com/okonet/listr-update-renderer/tarball/upgrade-log-update:
Integrity check failed for "listr-update-renderer" (computed integrity doesn't match our records,
got "sha1-Bgc/qTFmJ3YHp4FPTh+DlgCBQUw=")

Using a shared runner from gitlab-ci.

[rickmzp]

yarn remove lint-staged followed by yarn add lint-staged resolved it for us. Resulted in lint-staged being updated from 8.0.5 to 8.1.0 and listr-update-render to be updated from 0.4.0 to 0.5.0.

[vladgolubev]

A more elegant option will be running yarn upgrade lint-staged --dev which will upgrade all dependencies of lint-staged