Linkerd2: `top` output has no column headers

Created on 23 Jul 2019  路  3Comments  路  Source: linkerd/linkerd2

The output of linkerd top has no column headers, making it unclear what is actually being reported. (2.4.0)

image

arecli good first issue help wanted prioritP1

All 3 comments

This problem seems to cause from this line

termbox.SetCell(x, y, c, termbox.AttrBold, termbox.ColorDefault)

The param termbox.AttrBold should be set color but is not.
So both forground and background colors are termbox.ColorDefault (black).

We should set color white.

termbox.SetCell(x, y, c, termbox.AttrBold|termbox.ColorWhite, termbox.ColorDefault)

I'll make PR.

@wmorgan @aimof on what environment are you seeing this issue? I tried in iterm and terminal on MacOS and couldn't reproduce it.

Screen Shot 2019-07-29 at 10 17 37 AM
Screen Shot 2019-07-29 at 10 17 46 AM

Oops, this was user error on my part. Sorry! (I somehow ended up with bold text being the same color as the terminal background... which is a great way to confuse yourself.)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

manimaul picture manimaul  路  3Comments

briansmith picture briansmith  路  4Comments

franziskagoltz picture franziskagoltz  路  3Comments

zaharidichev picture zaharidichev  路  4Comments

steve-fraser picture steve-fraser  路  4Comments