Linkerd2: remove vertical line in dashboard header

Created on 19 Feb 2019  路  6Comments  路  Source: linkerd/linkerd2

Minor, but there is a vertical line in the dashboard header to the right of the Linkerd logo, and it would look better to follow the K8s dashboard's approach of "no such line".

image 14

areweb good first issue help wanted pinned prioritP1

All 6 comments

@wmorgan @grampelberg, do you want just a vertical line deletion in the header, or do you also want the behavior of the K8s dashboard, where the full header bar remains at the top of the screen when a user is scrolling downward?

K8s header when user is at top of screen:

k8s1

K8s header when user scrolls downward:

k8s2

Linkerd header when user is at top of screen:

linkerd1

Linkerd header when user scrolls downward:

linkerd2

To me, the K8s sticky header behavior is more clear, because the user always knows which section they're viewing. However, this will be a bit more reorganization of the code since currently the lefthand Drawer component is independent of the righthand Main content.

+1 to having it be sticky

Agreed!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

The line continues to haunt me

Closing - new design does not include a full-width vertical navbar

Was this page helpful?
0 / 5 - 0 ratings

Related issues

steve-fraser picture steve-fraser  路  4Comments

ihcsim picture ihcsim  路  4Comments

coleca picture coleca  路  4Comments

ihcsim picture ihcsim  路  4Comments

olix0r picture olix0r  路  3Comments