Linguist: Typescript repo beeing recognized as Javascript

[rafmst]

Problem Description

Could it be because of the .json files? Still, it should show 1% Typescript at least

URL of the affected repository:

https://github.com/rafmst/propor

Last modified on:

2019-07-10

Expected language:

Typescript

Detected language:

Javascript

[lildude]

Could it be because of the .json files?

Nope. It's because of the shebang:

#!/usr/bin/env node

Linguist considers node as an interpreter for Javascript, not Typescript:

https://github.com/github/linguist/blob/775b07d40c04ef6e0051a541886a8f1e30a892f4/lib/linguist/languages.yml#L2564-L2569

For Typescript, you'd need to either use deno or ts-node:

https://github.com/github/linguist/blob/775b07d40c04ef6e0051a541886a8f1e30a892f4/lib/linguist/languages.yml#L5595-L5602

[rafmst]

That explains it, I will try to fix it like you suggested. Thanks for the help, have a nice weekend 😁

[pchaigno]

@lildude I associated the node interpreter with TypeScript in #4261. When did we remove that?

[lildude]

When @Alhadis merged https://github.com/github/linguist/pull/4470 😁

The OP of the PR states:

UPDATE: This PR's been updated to remove node from TypeScript's interpreters list as well, following conversation between @pchaigno and @grant. Merging this PR will now also fix #4469.

[stale[bot]]

This issue has been automatically marked as stale because it has not had activity in a long time. If this issue is still relevant and should remain open, please reply with a short explanation (e.g. "I have checked the code and this issue is still relevant because ___."). Thank you for your contributions.

[stale[bot]]

This issue has been automatically closed because it has not had activity in a long time. Please feel free to reopen it or create a new issue.