Linguist: Release date for v6.0.2?

[stringfellow]

Preliminary Steps

Please confirm you have...

• [x] reviewed How Linguist Works,
• [x] reviewed the Troubleshooting docs,
• [x] considered implementing an override,
• [x] verified an issue has not already been logged for your issue (linguist issues).

Problem Description

There are a fair few commits in master since the last release, including some syntax highlighting which would be really good to have available on GitHub, so I was wondering what the process was to get a release out and then have that included in the latest GH release?

URL of the affected repository:

Last modified on:

Expected language:

Detected language:

[lildude]

I'm aiming for some time this week. I wanted to do it last week but didn't get the chance.

[worldbeater]

Please, consider also updating a reference to the latest https://github.com/atom/language-csharp grammar if you have any time! We've just finished working there on a new grammar providing first-class syntax highlighting for C# language on GitHub and in Atom (it uses Microsoft's grammar now, ported to support PCRE).

See it in action:

• Before vs After
• Before vs After
• Before vs After

Thanks in advance and keep up your great work!

[lildude]

I’ll perform a grammar update too so all grammars will be updated to their latest versions at the same time.

@damieng does ☝️ include the changes you mentioned earlier when you said you’d found a way to use the same grammar for GitHub and Atom?

[damieng]

@worldbeater produced a script that fixed up the grammar so it works in both and is fully merged into language-csharp.

I've done some preliminary testing and I am seeing some odd issues I'd like to investigate where lightshow is highlighting using keywords instead of entity names. I'll be able to spend some time checking this out this evening if that works with your timeline.

[lildude]

Yup, good for me. We've got a few other PRs I'd like to try sneak in before
I cut a new release so it may be late tomorrow or early Thursday before I
cut the release.
On Tue, 17 Apr 2018 at 19:38, Damien Guard [e-mail] wrote:

@worldbeater https://github.com/worldbeater produced a script that
fixed up the grammar so it works in both and is fully merged into
language-csharp.

I've done some preliminary testing and I am seeing some odd issues I'd
like to investigate where lightshow is highlighting using keywords instead
of entity names. I'll be able to spend some time checking this out this
evening if that works with your timeline.

—
You are receiving this because you commented.

Reply to this email directly, view it on GitHub
https://github.com/github/linguist/issues/4104#issuecomment-382098122,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAmSUDdvGGTNqaUfYu9gQxndpVLX8umVks5tpjaugaJpZM4TYVng
.

[damieng]

I just published 1.0.2 which solves those problems and now looks great. The only 'missing' feature is colorization of string interpolation which works in Atom but not in Linguist. Is there anything I need to do to make that happen?

(It's a relatively new feature and has never worked on github.com before in C# so this isn't a regression - just another opportunity for improvement)

[lildude]

The only 'missing' feature is colorization of string interpolation which works in Atom but not in Linguist. Is there anything I need to do to make that happen?

I don’t know, but @Alhadis may as I know he’s spent a lot of time playing with grammars.

[Alhadis]

@damieng I checked out atom/language-csharp locally and dev-linked it to ~/.atom/dev/packages, but I'm actually not seeing anything in Atom:

Is this what you're referring to by "string interpolation"? Or have I got that wrong?

[Alhadis]

Never mind, I really did get that wrong. 😅It needed a leading $. But it still appears to be working fine on GitHub's end.

Admittedly, the interpolations aren't terribly obvious due to having very similar colours...

[ghost]

I think this kind of variable interpolation is not highlighting correctly on GitHub:

c# var test = "foo"; Console.WriteLine($"Hello, {test}! Today is {1}, it's {2:HH:mm} now.", date.DayOfWeek, date);

(color of test)

[Alhadis]

@kasper3 Changes to Linguist don't take effect on GitHub until the next release, so until Linguist v6.0.2 is released, improvements to grammars won't be visible.

Hence the reason @stringfellow was asking. =)

[damieng]

Going to work on one more revision tonight to get the variable names to be black to be consistent with the current theme but then should be good to ship :)

[ghost]

@Alhadis, i tested that code on lightshow, on the link you posted, interpolated variable test has the same color.

[damieng]

That link works for me but the difference between the various colors in interpolated strings is very close. Inspecting element shows it correctly tokenizing constants etc. tho.

[ghost]

Maybe my expectation is wrong; to get color of {test} and :HH:mm same as {1}, {2?

[worldbeater]

@kasper3 it seems that only numbers and boolean values are highlighted using light blue color, and variable names and properties always use black color, string uses dark blue. I think it works so because syntax highlighting should be consistent and predictable. Numbers and booleans:

42 12345.24f true false

Strings:

"Hello, world!"

[Alhadis]

A shortlist of supported scope-names can be found at primer/github-syntax-light, with a more readable-looking list copied here.

If a scope appears to be "highlighted incorrectly", it might be that its choice of names are causing it not to be highlighted at all.

[damieng]

Thanks to the @worldbeater we look good to ship on language-csharp for github.com as of 1.0.3 that was just published!

[lildude]

Great!! I've not had the chance to build a test gem today as I've been trekking across London to get my race entry for Sunday's London Marathon, but I will cut the first test gem tomorrow morning :gb: time and test it. If all goes well, I hope to cut the final release gem by the end of the day or first thing on Monday with the aim of merging it mid-week pending PR approval etc.

[stringfellow]

Thanks @lildude and good luck with the marathon! Will cheer you on from the sides :)

[worldbeater]

YAY! It seems Linguist is now released and deployed, we can already see improvements in the C# grammar. The code now looks absolutely perfect. Thanks a lot and keep up your great work!

this.WhenAnyValue(x => x.LinguistRelease)
    .Where(x => x.TestsSucceeded)
    .InvokeCommand(DeployToGitHub);

[lildude]

Woohoo!!! 🎉

As we're now running 6.1.0, I'm gonna close this. Thanks for your patience peeps. 🙇 I hope to get into a regular monthly release cycle :soon:.

[stringfellow]

Thankyou @lildude, really appreciate it. Code review just got less painful :D