Linguist: Elm language's syntax highlighting seems broken
Example:
https://github.com/elm-lang/core/blob/master/src/Array.elm
This was working fine until I noticed it this morning. Any suggestion about what might go wrong?
Warry
All 15 comments
Yikes, and two days before elm-conf too. D:
rtfeldman
on 13 Sep 2016
Is _all_ Elm highlighting broken? We updated the Linguist gem last night which included some updates to the Elm grammar.
Looks like some additional scopes were added in https://github.com/github/linguist/commit/adaf4011bc629060f98a63625b3706ecfe9048d4. Any ideas @pchaigno?
arfon
on 13 Sep 2016
@arfon yep, all Elm files appear to highlight as 190% plaintext. Same symptoms as if the grammar had been removed.
rtfeldman
on 13 Sep 2016
@arfon yep, all Elm files appear to highlight as 190% plaintext. Same symptoms as if the grammar had been removed.
Ugh. Really sorry about this. I'll investigate and try and get a new (emergency) gem cut for Linguist tomorrow to fix this.
arfon
on 13 Sep 2016
I introduced the bug in adaf401. #3206 should fix this.
pchaigno
on 13 Sep 2016
Wait, this is all your fault?
You're fired, git out.
Alhadis
on 13 Sep 2016
I hate to bring bad news, but the fix doesn't seems to have done its magic.
Warry
on 13 Sep 2016
... nothing's been merged yet...
Alhadis
on 13 Sep 2016
Duh... my bad...
Warry
on 13 Sep 2016
@Warry #3206 has been merged. This issue should be fixed with the next release of Linguist, probably soon since @arfon said tomorrow 16 hours ago (I don't know on which timeline he is currently but unless he's not in the US that should be today :smile: )
pchaigno
on 13 Sep 2016
@pchaigno Sweet :) Thanks for the feedback, I'm sure the whole community will be happy to hear it !
Warry
on 13 Sep 2016
Awesome, thanks so much @pchaigno @arfon!
rtfeldman
on 13 Sep 2016
Just testing out #3212 in production:
arfon
on 13 Sep 2016
This is now fixed. Sorry for the trouble @Warry!
arfon
on 13 Sep 2016
เมื่อ 14 ก.ย. 2016 03:02 "Arfon Smith" [email protected] เขียนว่า
This is now fixed. Sorry for the trouble @Warry https://github.com/Warry
!—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/github/linguist/issues/3204#issuecomment-246805758,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARRCt6OmQMv0NcKGBTnQ-YgW7qXCm5Joks5qpwFcgaJpZM4J6fbh
.
preedee136
on 29 Sep 2016
Related issues
oldmud0
·
6Comments
BnSalahFahmi
·
3Comments
lucasrodes
·
6Comments
henrywright
·
6Comments
Haroenv
·
4Comments