Lighthouse: Dependency cleanup prior to mainnet

Created on 18 Nov 2020 · 5Comments · Source: sigp/lighthouse

Description

We currently have in place a number of forks in non-canonical repositories which are required as the underlying dependencies have not updated to the latest ecosystem versions.

Along side this we have dependencies of varying versions and we should, where possible attempt to combine them all into a single version.

Before going to mainnet we should also update all dependencies to their latest version.

Specific forked deps that should be looked at are:

sigp/warp
sigp/unsigned_varint
sigp/rust-libp2p

A0 t Admin

Source

AgeManning

👍1

Most helpful comment

Yeah the discv5 dep is sorted in #1839 which will be merging to unstable within the next day.

I think the blst library has a new version we can target. @kirk-baird

AgeManning on 26 Nov 2020

👍2

All 5 comments

While attempting to package lighthouse for NixOS I also run into issues with.

sigp/discv5 - which is included from git and not from crates.io
sigp/blst - which can't be properly cargo vendored when used from git

Cleaning these up would help.

bachp on 25 Nov 2020

Yeah the discv5 dep is sorted in #1839 which will be merging to unstable within the next day.

I think the blst library has a new version we can target. @kirk-baird

AgeManning on 26 Nov 2020

👍2

Submitted #1979 which could be used to fix the blst problem.

sean-sn on 26 Nov 2020

❤1

Currently still an issue on unstable with cargo vendor:

  found duplicate version of package `headers v0.3.2` vendored from two sources:

        source 1: registry `https://github.com/rust-lang/crates.io-index`
        source 2: https://github.com/blacktemplar/headers?branch=lighthouse#8bffbd8a

bachp on 10 Dec 2020

I think we can close this issue as a duplicate of https://github.com/sigp/lighthouse/issues/1712, at least the three mentioned dependencies are all listed there too.