Lighthouse: 'Links are not crawlable' audit should not apply to mailto: links

[coliff]

What is the current behavior?

Links with mailto: are listed as an SEO issue in the 'Links are not crawlable' section.

What is the expected behavior?

Links with mailto: should be ignored by the 'Links are not crawlable' audit

[patrickhulce]

Thanks for filing @coliff! This is a great first issue if anyone is interested :)

[MarianaPicolo]

Hey, @patrickhulce I'm interested in this one :)

Where could I start?

[patrickhulce]

Thanks @MarianaPicolo! You would add a line filtering out mailto: links in
https://github.com/GoogleChrome/lighthouse/blob/4335838135b1c254d1e66bb5d732f14b3b875ccf/lighthouse-core/audits/seo/crawlable-anchors.js#L60-L65 and a test to
https://github.com/GoogleChrome/lighthouse/blob/4335838135b1c254d1e66bb5d732f14b3b875ccf/lighthouse-core/test/audits/seo/crawlable-anchors-test.js#L36

but we already have one and this should be working!

@coliff could you share an example URL where this is happening? This should already be working...

[coliff]

@patrickhulce - apologies for the incomplete bug report!
My link actually has some JavaScript on it too to open the email in a window.

I made a quick test case example here:
https://tests.christianoliff.com/mailto/

Lighthouse SEO Report:
https://googlechrome.github.io/lighthouse/viewer/?psiurl=https%3A%2F%2Ftests.christianoliff.com%2Fmailto%2F&strategy=mobile&category=seo

I realise this may be quite an edge case, though it'd still be nice if it wasn't flagged as an issue.

[patrickhulce]

Ah thanks for the extra detail @coliff!

@MarianaPicolo the locations I linked are the same but we'll want to specifically address the case of a valid, crawlable href being used in combination with a window.open onclick handler.

For future issue readers, while I can see the argument that this is WAI because a dev could be sending the user somewhere else entirely in the onclick handler, it seems like a reasonable workaround for them to also state the crawlable destination in the href in which case the SEO concerns are moot.

[MarianaPicolo]

@MarianaPicolo the locations I linked are the same but we'll want to specifically address the case of a valid, crawlable href being used _in combination_ with a window.open onclick handler.

@patrickhulce can I check using the const hasClickHandler?

if (hasClickHandler && windowOpenRegExp.test(onclick)) return true;

[patrickhulce]

You don't need to use it at all, we're just ignoring mailto: links. That description was provided so you can find a test case that fails the audit before you fix and make sure it passes after your fix.

[Haugf]

Hi is this open again? @MarianaPicolo would you like to try and go through this again? Maybe I can try to help too

[MarianaPicolo]

Hi is this open again? @MarianaPicolo would you like to try and go through this again? Maybe I can try to help too

Sure!

Help is always welcome! :))

[Haugf]

Hey there everyone, I am back to this issue today! I just read through the contribution.md and signed the agreement.

I have a few questions:

• Is there any branch for this issue yet?
• What should I name the branch, if there isn't one yet?

🎃

[Haugf]

@coliff I ran a lighthouse report on https://tests.christianoliff.com/mailto/ and noticed I got a better report for SEO than you reported. Is there something I didn't do when replicating?

[patrickhulce]

Is there any branch for this issue yet?

Not unless you've worked out access to @MarianaPicolo 's fork.

What should I name the branch, if there isn't one yet?

Not sure important honestly, whatever you'd like on your fork :) I'll offer mailto_links_crawlable as a suggestion.

noticed I got a better report for SEO than you reported. Is there something I didn't do when replicating?

@Haugf are you sure you're testing with the latest master branch? I still see that URL failing.

[Haugf]

No I'm not testing on latest master, I just used my lighthouse from the Chrome dev tools

[stephenyu]

Hi, wondering if this issue is free and if I could pick it up? I've got a branch which should resolve this.

[patrickhulce]

I'm not sure @stephenyu it's been picked up by two people in the past but no PR has been created yet. @Haugf @MarianaPicolo have you stopped working on this?

If we don't get a reply soon, a PR would be very welcome @stephenyu :)

[Haugf]

Morning guys, I got busy with work so I have had to put hacktoberfest on
pause. Feel free to go for it Stephen, sorry to keep you waiting guys!

On Sat, Oct 10, 2020 at 10:35 PM Stephen [e-mail] wrote:

Hi, wondering if I could pick up this issue?

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/GoogleChrome/lighthouse/issues/11443#issuecomment-706640365,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGZ3E656SHAQMZJIASC2E53SKEKXBANCNFSM4RQC25GQ
.

>

Best,
Freddy Haug
9548997868

My pronouns
https://www.wellandgood.com/good-advice/personal-pronouns-email-signature/:
He, him