Lighthouse: Avoid an excess DOM size goes "Error!"

[Westbrook]

When auditing https://westbrook.github.io/minesweeper/ the "Avoid an excess DOM size" returns Error!.

Provide the steps to reproduce

1. Visit https://westbrook.github.io/minesweeper/
2. Run DevTools audit
3. See "Avoid an excess DOM size" report

What is the current behavior?

What is the expected behavior?

It tells me something useful... right?

Environment Information

• Affected Channels: DevTools
• Lighthouse version: Stable & Canary
• Operating System: Mac OS

Related issues

[patrickhulce]

Thanks for filing @Westbrook!

The full error message can be seen on hover, and this is indeed a bug!

[Westbrook]

Oh, great! Thanks for pointing that out, it will be super helpful if I run into future issues.

I would never have caught that bubble interaction, however. Seems like there might be room for some UI/X love on that (being the visuals tell me to toggle, not hover).

If there is anything else I can do to support clearing up this issue, please let me know.

[patrickhulce]

For anyone that might want to take this on, the error is being thrown here

https://github.com/GoogleChrome/lighthouse/blob/df85d681886d1ae163798c715fd29c72cc96c58f/lighthouse-core/lib/page-functions.js#L115-L126

A good fix might be to simply try/catch and return <${node.localName}> if we can't determine the full outerHTML :)

[NickolasBenakis]

I would like to work on this

[connorjclark]

thanks @NickolasBenakis!

Tried to assign you but I guess only project members can be assigned to issues :) anyway, go for it

[NickolasBenakis]

I fixed it!

[brendankenny]

Fixed by #9079