Lighthouse: [Lightwallet] Support timings in budgets UI

Created on 10 May 2019  ·  4Comments  ·  Source: GoogleChrome/lighthouse

How timings budgets are shown in case when they are not met?

Could you please confirm that currently budget for timings metrics are working properly? As I see right now in html report is no clear information about if the budget have been met.

Budget definition:
image

Steps to reproduce

  1. Run lighthouse https://youtube.com --budget-path=lighthouse-core/test/fixtures/simple-budget.json in console (CMD or GitBash on Windows)
  2. Open generated report

Current behavior:
Generated HTML report does not have clear information about timings budget, like for resourceSizes.

Report:
image

Question:
Is described behavior an expected one? Or for timings should be also displayed table with information about current value of metric and expected budget, defined in json file like in case of resources?

feature needs-priority

Most helpful comment

Budgets only assert on the file sizes at the moment, metric timings are pending so stay tuned :)

All 4 comments

Budgets only assert on the file sizes at the moment, metric timings are pending so stay tuned :)

Cool stuff!

Thank you for answer @patrickhulce !

Do you have any public roadmap to view what features can come next months?

@Danon9111 not that's neatly organized into releases but you can take a look at issues with the P1 and P1.5 label to get an idea :)

Was this page helpful?
0 / 5 - 0 ratings