Lighthouse: Locale Support

Created on 20 Apr 2018  路  6Comments  路  Source: GoogleChrome/lighthouse

Will lighthouse support different locales?

PageSpeed insights does and has a lot of the same content
https://developers.google.com/speed/docs/insights/v4/reference/pagespeedapi/runpagespeed

feature needs-priority report

Most helpful comment

I think we need to do a bit of scoping before we jump in on impl for this one @ev1stensberg.

A few things to figure out:

  • What channels would this affect/how would it be distributed?

    • DevTools doesn't offer translations, so we wouldn't apply it there

    • Extension as an option based on Chrome lang?

    • CLI/node flag and we ship all?

  • How does this impact linked docs/who maintains those?
  • How does this impact our PR process for text changes?
  • How high a priority is this/which languages are most urgent?

We'll try and tackle some of these questions in our next triage post-I/O :)

All 6 comments

Willing to work on this, but what do you mean with locale? Formatting scores to be displayed for certain languages or formats?

Specifically, translations for the explanations and instructions

Alright, thanks for elaborating @sgryschuk-va! @patrickhulce is this up for grabs?

I think we need to do a bit of scoping before we jump in on impl for this one @ev1stensberg.

A few things to figure out:

  • What channels would this affect/how would it be distributed?

    • DevTools doesn't offer translations, so we wouldn't apply it there

    • Extension as an option based on Chrome lang?

    • CLI/node flag and we ship all?

  • How does this impact linked docs/who maintains those?
  • How does this impact our PR process for text changes?
  • How high a priority is this/which languages are most urgent?

We'll try and tackle some of these questions in our next triage post-I/O :)

May I suggest starting with the Lighthouse Report Viewer ? I think it would be the easiest to implement IMO. We can download the json regardless of locale, upload it to the report viewer and switch the locale in there. Am I crazy?

We support locales now (in master branch). :)

This was tracked mostly by the #5719 ticket

Was this page helpful?
0 / 5 - 0 ratings