Lighthouse: Chrome's infobars distort screenshots

Created on 7 Feb 2018  路  12Comments  路  Source: GoogleChrome/lighthouse

Some indicators are not normal due to "Auto Translate". The screenshots too.
I have to deal with pwmetrics#140 to solve this issue.

Enable auto translate

2018-02-08 1 40 44

Disable auto translate

2018-02-08 1 40 52

Do you have any plan for this issue?
Thanks.

ps. My env is

  • Chrome Version 66.0.3342.0 (Official Build) canary (64-bit)
  • lighthouse 2.8.0

ref.

P1.5 bug extension

Most helpful comment

Ah! so --disable-infobars was also removed! oh boy.

@mixed a shortterm fix for you: --enable-translate-new-ux. This uses a different dialog instead of the infobar and so screenshots are fixed.

I'll still look into:

1) how we can avoid all infobars
2) if we can fix screenshots while infobars are shown.

All 12 comments

thanks for reporting! does --disable-infobars fix the bad screenshots?

@paulirish
Yes. It is still not disabled auto translate. 馃槩

hmm.. still trying to understand.

two questions:

1) do you see an infobar like this one show up when LH is loading this page?
image

2) does chrome actually change the page contents (translating them to english or another language)?

1.do you see an infobar like this one show up when LH is loading this page?

---> Yes

2.does chrome actually change the page contents (translating them to english or another language)?

---> No

And My OS is Mac(OS X El Capitan - 10.11.4).

Show infobar and Not translate.
2018-02-08 2 03 20

A ha!

The infobar is messing up the screenshots (which will also mess up our speed index calculations).

And this is why we have bad screenshots in the extension. Because it always has a infobar while it's doing its thing.

@paulirish
Yes. You're Right. Currently I have to deal with https://github.com/paulirish/pwmetrics/issues/140#issuecomment-343197696 to solve this issue. Do you recommend setting the profile?

Ah! so --disable-infobars was also removed! oh boy.

@mixed a shortterm fix for you: --enable-translate-new-ux. This uses a different dialog instead of the infobar and so screenshots are fixed.

I'll still look into:

1) how we can avoid all infobars
2) if we can fix screenshots while infobars are shown.

Oh. Thanks @paulirish
I fixed using --enable-translate-new-ux more easy.

seems like this is fixed now with the new translate UI now used everywhere?

Ah. Yes the translate stuff is good now since it uses a diff infobar.

However the Chrome extension still trigger a full-width infobar which still messes up the screenshots.

image

So mixed's original issue is resolved, but this ticket is now tracking the generalized chrome extension issue.

sounds perfect for #2287 :)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

muuvmuuv picture muuvmuuv  路  3Comments

dkajtoch picture dkajtoch  路  3Comments

nl-igor picture nl-igor  路  3Comments

asistapl picture asistapl  路  3Comments

codepodu picture codepodu  路  3Comments