Lighthouse: Render-blocking script warnings should exclude <script type="module">

Created on 17 Sep 2017 · 8Comments · Source: GoogleChrome/lighthouse

The logic here should be updated to check for the module attribute:
https://github.com/GoogleChrome/lighthouse/blob/63b4ac14d0a871ade0630db2885edd7848843243/lighthouse-core/gather/gatherers/dobetterweb/tags-blocking-first-paint.js#L32-L36

P1 bug gatherers good first issue

Source

philipwalton

👍3

All 8 comments

Thx for filing. Good call.

paulirish on 20 Sep 2017

Can I work on this?

FYI: I already merged my first feature to lighthouse sometime back. So, It is not actually first bug for me. Is it okay to work on these? I see a bunch of first bug lying around. I would love to do them all :)

thisizkp on 2 Oct 2017

👍1

@ThisIzKp go for it! You're still early enough to take "good first bugs", and this one's high enough priority to not let it sit around :)

patrickhulce on 2 Oct 2017

👍1

@ThisIzKp are you taking this? no worries if not.. it's an easy one.

paulirish on 12 Oct 2017

@paulirish You self assigned this to yourself, so I thought you're picking this up. I can work on it, if you haven't started it yet.

thisizkp on 22 Oct 2017

Small PR, so I'll do this today evening, will raise a PR by tomorrow :-)

thisizkp on 27 Oct 2017

ok sounds good

paulirish on 27 Oct 2017

@paulirish raised the PR, not sure about how to handle nomodule fallback.
If nomodule fallback is sync by default then it is already covered by the existing code, but if nomodule fallback is defer (like type=module) then we need to handle that case also.

Let me know your thoughts about that

thisizkp on 28 Oct 2017

Was this page helpful?

0 / 5 - 0 ratings