Lighthouse: Node version 4 and ES5 support?

Created on 18 Jul 2017  路  7Comments  路  Source: GoogleChrome/lighthouse

Chrome Launcher does not support Node v4.8.1 nor does it support ES5. Are there plans for this or are there any workarounds for applications written in ES5?

Most helpful comment

we will need to add 4.x to our testing matrix.
https://github.com/GoogleChrome/lighthouse/blob/master/.travis.yml

I am -1 to supporting node version outside of LTS though and would prefer to be inline with lighthouse.

All 7 comments

We could explore workarounds for those sticking to earlier versions of Node (suggestions/advice welcome!), but generally the policy is to keep support at the current Node LTS version (currently Node v6).

We could explore workarounds for those sticking to earlier versions of Node (suggestions/advice welcome!)

Any objections to just flipping the target in tsconfig to es5?

cc: @samccone

oh, good point, just the launcher. The generated code is already pretty ugly, couldn't get much worse :)

we will need to add 4.x to our testing matrix.
https://github.com/GoogleChrome/lighthouse/blob/master/.travis.yml

I am -1 to supporting node version outside of LTS though and would prefer to be inline with lighthouse.

@bliu23 If you want I can help you setup chrome-launcher for node 4 so you can build it yourself, of course it would be some manual work you'll have to do each time we update the launcher

That would be great actually. An upgrade to Node 6 is on the drawing board, but we'll definitely need a fix until then.

This issue was moved to GoogleChrome/chrome-launcher#8

Was this page helpful?
0 / 5 - 0 ratings

Related issues

muuvmuuv picture muuvmuuv  路  3Comments

codepodu picture codepodu  路  3Comments

Simply007 picture Simply007  路  3Comments

johnfrancisli picture johnfrancisli  路  3Comments

bitttttten picture bitttttten  路  3Comments