Lighthouse: Lighthouse treats "shrink-to-fit" property in meta-tag "viewport" as invalid

[zhirzh]

In lighthouse audits,
this will pass:
<meta name="viewport" content="width=device-width, initial-scale=1">
this will fail:
<meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
with message Invalid properties found: {"shrink-to-fit":"no"}.

[patrickhulce]

Thanks for the report @zhirzh! Looks like our dependency for metaviewport parsing hasn't been updated in quite some time.

[zhirzh]

@patrickhulce that's not even my handle :joy:

[patrickhulce]

oops 😆 fixed! haha sorry for the spam other similarly named LH-contributor :)

[evenstensberg]

What should we do to chase this down?

[patrickhulce]

@ev1stensberg since that package doesn't seem very well maintained, we should probably add a temporary workaround to ignore shrink-to-fit in the audit for now

In the long term we'll need to decide if we want to...

• work with the owner to get a fix in place and published
• bring it into third_party and fix
• drop the package and parse the values ourselves

[evenstensberg]

I can work on long term if you want to, better fix now than never :)

[hmelenok]

@patrickhulce i fix it for you, guys please review it dontcallmedom/metaviewport-parser/pull/4

[hmelenok]

@patrickhulce GoogleChrome/lighthouse/pull/2863 with updated version

[paulirish]

fixed by #2863

[jamesvclements]

Hey I'm still getting this as a problem on the chrome extension:

The viewport audit has a ✅ but is considered failed w/ the invalid shrink-to-fit property.
I ran it on the default build of create-react-app

[PatNeedham]

I'm still getting that same problem on the chrome extension @jamesvclements is referring to as well, ran on the default build of create-react-app.

[evenstensberg]

Needs reinvestigation @patrickhulce

[brendankenny]

I think this is due to the release of the extension lagging behind (it's still on 2.3.0). We're hoping to do a release of 2.5.0 on all platforms early next week.

[Foorack]

Any update on this? I am still experiencing this in Chrome 62.

[patrickhulce]

@Foorack this was fixed on august 7, use Chrome Canary, the CLI, or the extension for latest LH version with the fix