Lighthouse: Cleanup work to publish chrome-launcher

[samccone]

TODO:
https://github.com/GoogleChrome/lighthouse/commit/7673d156131a9cfc33c38b55ec0775326bd73524

Also:
Need to figure out how to share log

[paulirish]

also: make sure the mkdirp type will be exposed to projects consuming LH as a dep
https://github.com/paulirish/pwmetrics/pull/120#issuecomment-302119936

(should be automatic)

[paulirish]

Need to figure out how to share log

one answer might be to pull in "debug": "2.2.0", as a dep of c-launcher and use that directly. I think the only gotcha is dealing with loglevel and our --verbose flag, etc?

[pedro93]

Any update on this?

[samccone]

I am working on it now :)

[jooj123]

@samccone any update on this one? Seems to be blocking: https://github.com/paulirish/pwmetrics/pull/120

[ebidel]

@jooj123, https://github.com/GoogleChrome/lighthouse/pull/2358/files is close. Just a few comments to address.

[samccone]

@jooj123 I have been working on this for a while now, a fair amount of work was required to correctly extract this in a non-debt inducing way

https://github.com/GoogleChrome/lighthouse/issues/2092

Hope to get this landed quite soon. Thanks

[paulirish]

Now published on npm as chrome-launcher.

docs: https://github.com/GoogleChrome/lighthouse/tree/master/chrome-launcher

[brendankenny]

🎉 🎉 🌮 🎉 🎉 🎉 🎉 🎉

[jooj123]

awesome thanks guys 🎉

[ebidel]

Nice work!

On Wed, Jun 14, 2017 at 12:26 AM Martin Jujou [e-mail]
wrote:

awesome thanks guys 🎉

—
You are receiving this because you commented.

Reply to this email directly, view it on GitHub
https://github.com/GoogleChrome/lighthouse/issues/2251#issuecomment-308343936,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOigME4Is82T6vwEiyYWEnTDnXavvAkks5sD4swgaJpZM4NbYfc
.