Libuv: Release proposal: v1.41.0

Created on 5 Jan 2021  路  12Comments  路  Source: libuv/libuv

I'd like to release v1.41.0 this week. Please leave any questions, comments, and concerns.

Notable changes:

  • The IBM i platform has been promoted to a Tier 2 platform.
  • libuv is now built with -fno-strict-aliasing, and recommends that projects using libuv do the same.
  • uv_fs_mkdir() now returns UV_EINVAL for invalid directory names on Windows.
  • uv_uptime() now returns the correct value on OpenVZ containers.
  • Windows 8 is the new minimum supported version of Windows.
  • Bind errors are now reported from uv_tcp_connect().
  • The uv_pipe() function has been added.
  • The uv_socketpair() function has been added.
  • uv_read_start() error handling has been unified across Windows and Unix.

Most helpful comment

https://github.com/libuv/libuv/pull/3064 also is 95% ready, if that is of interest

All 12 comments

SGTM. I've been holding off merging a few PRs until after this release, since it will break some flaky nodejs's tests. I've given them the PR to fix their tests nearly 2 months ago (https://github.com/nodejs/node/pull/36111), so I'm inclined to put more pressure on that by adding those PRs to the next release of libuv after this one (https://github.com/libuv/libuv/pull/3036, https://github.com/libuv/libuv/pull/3006, and https://github.com/libuv/libuv/pull/2874).

https://github.com/libuv/libuv/pull/3064 also is 95% ready, if that is of interest

3064 also is 95% ready, if that is of interest

I'm OK with waiting for that to land.

FWIW, #3064 is code-wise ready to be merged as far as I can tell. The output of Jenkins show unit test failures, but they don't seem related, and seem to have failed before too. Unless I'm reading things wrong, in which case happy to fix whatever is needed.

@vtjnash @cjihrig I want to surface here what @pdesantis mentioned in #3064: those responsible for the code of that PR (mostly me) are going to be out starting Feb 1st for three weeks, so if there's stuff to be done in that PR it'd be great to know before this Friday 29th, so we can address promptly and not delay 1.41.0.

How is progress on this going?

@cjihrig https://github.com/libuv/libuv/pull/3064 already landed.

Thanks @santigimeno. Let's see how the CI looks:

CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/2121/
Node.js integration CI: https://ci.nodejs.org/view/libuv/job/libuv-in-node/174/

It looks like there are a number of failures in the Node.js test suite related to child processes. https://github.com/libuv/libuv/pull/3064 seems like a potential cause.

I suspect so too. Since @jpcanepa can't look for a couple weeks, I recommend reverting that and doing the release without it now.

Revert in #3107.

I believe the release is ready to go. The most recent libuv CI came back green (https://ci.nodejs.org/view/libuv/job/libuv-test-commit/2125/). The most recent Node.js integration CI had some ARM failures, but they appear to be infrastructure related, and Node's own PRs are currently failing in the same way.

I plan to cut the release tonight or tomorrow.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jorangreef picture jorangreef  路  9Comments

imran-iq picture imran-iq  路  7Comments

cjihrig picture cjihrig  路  5Comments

Archcry picture Archcry  路  6Comments

cjihrig picture cjihrig  路  4Comments