I added in my PR #2198 a new flag and suppressed it in tests/icheck.suppression but
the build server says:
scripts/run_icheck: 51: scripts/run_icheck: ex: not found
I think the command ex is not installed on the build server because I work with the docker image locally and installed vim by hand and the run_icheckwent through.
i would prefer to not install even more into our images (they are bloated as is). Can the line be rewritten to use sed or another already available tool?
If ed is available, it should work after you replace:
ex '+g/^.*'"$line"'.*$/d' -cwq "$ICHECK_DIR/new_interface.h"
with
printf 'H\ng/^.*%s.*$/d\nw\n' "$line" | ed -s "$ICHECK_DIR/new_interface.h"
.
ok, I will rewrite it!
Well ed is not in the image.
Well
edis not in the image.
In that case I think we should just install ed. It is a standard POSIX utility after all.
I added ed to the docker image and used the change suggested by @sanssecours in #2198 and it worked!
PR #2198 is merged thus this issue resolved!
Most helpful comment
I added
edto the docker image and used the change suggested by @sanssecours in #2198 and it worked!