Libelektra: homepage: cannot follow any link

[markus2330]

Seems like the homepage build went through: https://build.libelektra.org/jenkins/job/elektra-homepage/224/console

(Although there is an ssh error at the end?)

It seems like a new homepage is online but it is completely broken: no link is working (you simply stay at the main page). Entering existing links leads to a white page.

@BernhardDenner Please fix, we want to release today but we cannot with this situation.

@Namoshek Do you have any idea?

[sanssecours]

It seems like a new homepage is online but it is completely broken: no link is working (you simply stay at the main page).

Strange, the homepage seems to work correctly in my browser.

[BernhardDenner]

Yes, because I've reverted it TP the old Version again.

Am 31.10.2017 8:12 vorm. schrieb "René Schwaiger" <[email protected]

:

It seems like a new homepage is online but it is completely broken: no
link is working (you simply stay at the main page).

Strange, the homepage seems to work correctly in my browser.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/ElektraInitiative/libelektra/issues/1676#issuecomment-340679000,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACmH3R05Jyhe_mtNMDIrD2mpsnEJYtaSks5sxshmgaJpZM4QMPie
.

[markus2330]

@BernhardDenner Thank you for working on it, that is great! Can you post in detail here what you changed, to help us ( @Namoshek ?) to locate the issue.

• Did nodejs change?
• Which rewrite rules do we have now?

A local build of the website displayed with grunt worked for me some days ago.

Is this one issue or several?

• [ ] Cannot follow any link on the web site.
• [ ] A blank page is shown when directly visiting a website.

When searching for this, I found suggestions to change something within Angular JS, but this seems ill-advised as it is working in other setups? (E.g. locally with grunt)

[BernhardDenner]

Can this be a result of a dependency problem?
Browsers console issues:

TypeError: $http.get(...).success is not a function

output of kdb build-rest-frontend

+ kdb build-rest-frontend
Running "less:build" (less) task
>> 2 stylesheets created.

Running "cssmin:build" (cssmin) task
>> 2 files created. 227.35 kB → 182.18 kB

Running "concat:vendor" (concat) task

Running "concat:pacejs" (concat) task

Running "concat:pacecss" (concat) task

Running "create-website-news:build" (create-website-news) task
>> Found file `_2017-10-25_0.8.20.md`, which has an inappropriate filename, in the news folder.
>> News post 2014-10-22_augeas.md has no short description matching the configured regex!
>> Website news file generated successfully!

Running "create-website-news-rss:build" (create-website-news-rss) task
>> News post undefined has no guid that can be used to generate an RSS post!
>> News post undefined has no guid that can be used to generate an RSS post!
>> Website RSS news generated successfully!

Running "create-website-structure:build" (create-website-structure) task
>> Website structure file generated successfully!

Running "copy-website-content:build" (copy-website-content) task
>> Website content copied to target directory successfully!

Running "copy:build" (copy) task
Copied 4 files

Running "create-website-sitemap:build" (create-website-sitemap) task

Running "preprocess:config" (preprocess) task

Running "preprocess:index" (preprocess) task

Running "browserify:build" (browserify) task
>> Bundle resources/application.js.tmp created.

Running "uglify:build" (uglify) task
>> 1 sourcemap created.
>> 1 file created 3.51 MB → 1.59 MB

Done.

[BernhardDenner]

$ lsb_release -a
No LSB modules are available.
Distributor ID: Debian
Description:    Debian GNU/Linux 9.1 (stretch)
Release:        9.1
Codename:       stretch

$ nodejs -v
v6.11.4

$ npm -v
3.10.10

[BernhardDenner]

hmmm: https://stackoverflow.com/questions/41169385/http-get-success-is-not-a-function
package.json says:

       "angular": "^1.5.8",

can this be related to that issue???

[markus2330]

I just tried with the same nodejs version: Only get some deprecated warnings about connect, minimatch, http2, but everything works as expected (locally with grunt). But when doing a new Elektra installation, it fails with a fsevents dependency problem.

On a complety new installed Debian system with nodejs 6.11.5, however, it works without problems.

So I would suggest to remove the npm cache and/or try upgrading to nodejs 6.11.5.

[Namoshek]

Yes, this may be the issue @BernhardDenner (although it seems weird because breaking changes should be prevented by the used semver syntax). Try removing the leading ^ and with some luck it works again. Possible reason is given here in their changelog.

Alternative would be to keep the current npm setting, which is to use the most recent angular version (without breaking changes, so it would be 1.5.11 actually), and to change all calls in the code. Old syntax is $http.get(...).success(function (data, status, headers, config) { ... }).error(function (data, status, headers, config) { ... }); vs. the new one $http.get(...).then(function (response) { ... }, function (response) { ... }); (where the first function is the success and the second the error handler). The response object of the callbacks has all the properties that were given to the function in the old syntax directly (e.g. response.status, response.data, ...). An explanation is given in their changelog as well.

I'm not sure if the security related fixes are worth updating and changing quite some calls...

[BernhardDenner]

Since I've started before your reply, I'm going the hard way of fixing all http.get calls.
Until now, I've manually fixed and updated most of them (hopefully). So please test and report any issues. The login isn't working right now, I'm already fixing that.

[markus2330]

Thanks for creating #1678. I'll leave it open a bit to give @Namoshek time to have a look at it.

[markus2330]

Thank you for your dedication! Good to see this fixed!