Libelektra: ELEKTRA_PLUGIN_NAME

[markus2330]

Build system should provide:

• a string that contains the plugin/module name
• a non-string variant of the plugin/module name

Then ELEKTRA_PLUGIN_EXPORT, ELEKTRA_PLUGIN_FUNCTION, ELEKTRA_README would have one paramter less.

[markus2330]

@petermax2 Do you maybe want to implement this?

[petermax2]

Yes, you can assign me if the implementation is not time critical. At the moment I have not so much spare time.

[markus2330]

Thank you for working on this!

The actual reason to do this, is that every plugin has something like CRYPTO_PLUGIN_FUNCTION available and that CRYPTO_PLUGIN_FUNCTION is not needed anymore.

Btw. ARG_COMPILE_DEFINITIONS cannot be modified (due to restore_variable), so simply add further definitions in cmake/Modules/LibAddPlugin.cmake line 155 (where COMPILE_DEFINITIONS are defined).

[petermax2]

Btw. ARG_COMPILE_DEFINITIONS cannot be modified (due to restore_variable), so simply add further definitions in cmake/Modules/LibAddPlugin.cmake line 155 (where COMPILE_DEFINITIONS are defined).

It works for "regular" plugins (without compilation variant), now I'm looking into plugin variants.

[markus2330]

Great that you have progress!

[petermax2]

Progress so far

2360 : The CMake module add_plugin provides the following compiler definitions for every plugin:

• ELEKTRA_PLUGIN_NAME: the plugin name (including the variant if any) as string
• ELEKTRA_PLUGIN_NAME_C: the plugin name without quotes, so it can be used to construct function names, that depend on the plugin name/variant.

The removal of unnecessary parameters of ELEKTRA_PLUGIN_FUNCTION and CRYPTO_PLUGIN_FUNCTION will be implemented in another PR.

[markus2330]

So ELEKTRA_PLUGIN_EXPORT and ELEKTRA_README are the last left-overs?

[petermax2]

So ELEKTRA_PLUGIN_EXPORT and ELEKTRA_README are the last left-overs?

Yes, should be very easy and straight-forward now that ELEKTRA_PLUGIN_FUNCTION works.

[markus2330]

We finally did it!