Lemmy: Lemmy doesnt run / build / compile on Rust 1.48 and nightly

Created on 16 Nov 2020  路  4Comments  路  Source: LemmyNet/lemmy

Due to a problem in the config-rs crate

bug

All 4 comments

I have disabled our integration tests, as they are failing due to the crash in config-rs. We need to enable them again once that is fixed.

https://github.com/LemmyNet/lemmy/commit/841ad8476cf2f4a63204ff85bba56b4785962acd#diff-7ff815b68943f08bef79f083c09e55ca8c18db8e25033034b12fa31f1d43dab4

Based on @canop 's recommendations here, and because ~4 libraries are abandoned (config-rs, serde-yaml, hjson-rust (serde-hjson), linked-hash-map), and I think our best bet is to :

  • Remove config-rs entirely.
  • Use @canop 's deser-hjson library, which should be straightforward since we have a well-typed config anyway.
  • Use this rust merge library, in order to merge our default and custom config
  • Then the only thing we're missing is environment variables, which we could do away with entirely.

This is fixed now, Lemmy runs on Rust 1.50 and nightly :)

Yaaaaaaay.

Was this page helpful?
0 / 5 - 0 ratings