leftwm-git failed to build (aur)

[jwnpoh]

Hello, as specified in title. The latest git version does not seem to build. Here's the error message:

error[E0658]: use of unstable library feature 'unsigned_abs'
  --> src/models/tag.rs:46:27
   |
46 |             *mwp -= delta.unsigned_abs();
   |                           ^^^^^^^^^^^^
   |
   = note: see issue #74913 <https://github.com/rust-lang/rust/issues/74913> for more information

error: aborting due to previous error

For more information about this error, try `rustc --explain E0658`.
error: could not compile `leftwm`

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
error: build failed
==> ERROR: A failure occurred in build().
    Aborting...
:: Packages failed to build: leftwm-git-2:0.2.7.r21.g3f30650-2

I checked rustc --explain E0658 and it seems that the error in question is a feature that's only available in the nightly version of rust.

Here's the output from rustc:

#[repr(u128)] // error: use of unstable library feature 'repr128'
enum Foo {
    Bar(u64),
}

If you're using a stable or a beta version of rustc, you won't be able to use
any unstable features. In order to do so, please switch to a nightly version of
rustc (by using rustup).

If you're using a nightly version of rustc, just add the corresponding feature
to be able to use it:

#![feature(repr128)]

#[repr(u128)] // ok!
enum Foo {
    Bar(u64),
}

Must I switch to rust nightly to enjoy the updated leftwm?

[mautamu]

Tagging #305, which introduced that line.

It appears nightly is now required; since CI passed it I guess CI also uses nightly. I know in LeftWM-theme we intentionally avoided nightly: https://github.com/leftwm/leftwm-theme/commit/b2bf0b5e16fbc3b8aa469a6514a66614e248f353 , would we like to revert to stable here?

[VuiMuich]

I feel like nightly features that have a clear path to stable in reasonable time might be ok for branches and git-releases or for bin-package-releases.
Locally compiled stable releases should rely on stable rust, IMO.

[AethanFoot]

This was actually added to stable in the lastest 1.51. Have you updated rustup?
Also as a side note, I think (if it isnt already) we should restrict to stable options.
Thanks.

[jwnpoh]

This was actually added to stable in the lastest 1.51. Have you updated rustup?

This did it! Is there a way for the AUR pkgbuild to include a check of the rust version and prompt an update? I suspect my running into this issue this might have to do with my having install rust separately? Wondering if someone else might run into similar issue if they forget to update rustup.

[AethanFoot]

Im not sure with that. Is it possible to require version 1.51 in leftwms cargo.toml? This would atleast give a better error, if possible.

[VuiMuich]

It should be possible with a rust-toolchain.toml but after a biref read-up I think it might be better to handle this in the packaging script and either exit with a warning or try to use overrides to use the desired toolchain.
Doing so would allow to be more flexible in the active development to use whatever rustc version them developers like, while the package should also be able to correctly build.

[rebuilt]

This was actually added to stable in the lastest 1.51. Have you updated rustup?
Also as a side note, I think (if it isnt already) we should restrict to stable options.
Thanks.

Thanks I got it to compile after 'rustup update'