Ledger-live-desktop: Bitcoins on the testnet show a value

Created on 17 Jan 2019  路  5Comments  路  Source: LedgerHQ/ledger-live-desktop

Ledger Live Version and Operating System

  • tested on Ledger Live 1.3.0
  • Platform and version: Windows 10/macOS Mojave

Expected behavior

Bitcoins on the testnet have no value, so it should'nt display a value.

Actual behavior

Bitcoins on the Testnet display the normal BTC price.
This can be pretty annoying if you have other accounts.

Steps to reproduce the behavior

  • Add a BTC testnet account to ledger live
  • Receive some BTC on the testnet.
enhancement good first issue
Source
picture Luuk2016

All 5 comments

We are aware of this, it's currently using the BTC value for the fiat calculation, I personally agree it should show either zero or unavailable since they have no value.

juan-cortes picture juan-cortes on 20 Jan 2019
👍1

Yeah we could easily shortcut it in live-common. If currency.isTestnetFor then you returns 0 in the calculation function.

gre picture gre on 20 Jan 2019
👍1

@gre Would it be something that i can easily change with a PR?

Luuk2016 picture Luuk2016 on 21 Jan 2019
🎉1

@Luuk2016 returning 0 in the getRate function if the pair.from currency has a isTestnetFor should do the trick

meriadec picture meriadec on 21 Jan 2019
👍1

Created a PR
Sorry if i am totally wrong, my JS knowledge isn't that great. 馃槥

Luuk2016 picture Luuk2016 on 21 Jan 2019
Was this page helpful?
0 / 5 - 0 ratings

Related issues

pollastri-pierre picture pollastri-pierre  路  5Comments
pollastri-pierre picture pollastri-pierre  路  3Comments
Urgo picture Urgo  路  3Comments
staticfrost picture staticfrost  路  4Comments
juan-cortes picture juan-cortes  路  4Comments